#51523 closed enhancement (fixed)
Updates Screen: remove the "check again" `button` CSS class for better visual hierarchy
Reported by: | audrasjb | Owned by: | helen |
---|---|---|---|
Milestone: | 5.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Upgrade/Install | Keywords: | has-patch has-screenshots commit |
Focuses: | Cc: |
Description
In the core-auto-updates
Slack channel, @karmatosed pointed out that the "Check again" button would benefits to looks like a link and not a button. Indeed, there are many buttons on this screen and this one doesn't have the same place ion the screen hierarchy than the other ones. Moreover, this button is actually… a link. So there is no accessibility issue to make it looks like a link :)
Attachments (4)
Change History (13)
@
4 years ago
Upgrade/Install: Replace "Check again" button style with normal link style for better visual hierarchy.
#2
@
4 years ago
- Keywords has-patch has-screenshots needs-design-feedback added; needs-patch removed
Pinging @karmatosed for a quick design review :)
#3
@
4 years ago
- Keywords needs-design-feedback removed
Wow, that was fast! This is awesome and quick design review is to ship it!
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
4 years ago
#6
@
4 years ago
I attached a screenshot with this patch when no updates are available, just for reference. I think it does still look better to not have two secondary buttons, perhaps especially without a primary button present.
I also traced back through history and this was always a button, so no need to worry that we're undoing a previous decision to make this a button. Will handle commit momentarily.
#7
@
4 years ago
- Owner set to helen
- Resolution set to fixed
- Status changed from new to closed
In 49150:
#8
@
4 years ago
Totally in favor of making "Check Again" look like a link. Just a quick question: since this is now a link that looks like a link, does it still make sense to use title case? A textual link using title case seems a bit odd to me. I'd tend to think it should now use sentence case. Maybe also consider to add a period after the link.
Thanks for making this ticket @audrasjb, it's a great little benefit here to ease the complexity of the screen with numerous buttons.