WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#51523 closed enhancement (fixed)

Updates Screen: remove the "check again" `button` CSS class for better visual hierarchy

Reported by: audrasjb Owned by: helen
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch has-screenshots commit
Focuses: Cc:

Description

In the core-auto-updates Slack channel, @karmatosed pointed out that the "Check again" button would benefits to looks like a link and not a button. Indeed, there are many buttons on this screen and this one doesn't have the same place ion the screen hierarchy than the other ones. Moreover, this button is actually… a link. So there is no accessibility issue to make it looks like a link :)

Attachments (4)

51523.diff (764 bytes) - added by audrasjb 3 months ago.
Upgrade/Install: Replace "Check again" button style with normal link style for better visual hierarchy.
Capture d’écran 2020-10-14 à 21.47.12.png (100.2 KB) - added by audrasjb 3 months ago.
Before patch
Capture d’écran 2020-10-14 à 21.45.35.png (98.4 KB) - added by audrasjb 3 months ago.
After patch
Screen Shot 2020-10-14 at 2.17.14 PM.png (34.6 KB) - added by helen 3 months ago.
After patch, no updates available

Download all attachments as: .zip

Change History (13)

#1 @karmatosed
3 months ago

Thanks for making this ticket @audrasjb, it's a great little benefit here to ease the complexity of the screen with numerous buttons.

@audrasjb
3 months ago

Upgrade/Install: Replace "Check again" button style with normal link style for better visual hierarchy.

#2 @audrasjb
3 months ago

  • Keywords has-patch has-screenshots needs-design-feedback added; needs-patch removed

Pinging @karmatosed for a quick design review :)

#3 @karmatosed
3 months ago

  • Keywords needs-design-feedback removed

Wow, that was fast! This is awesome and quick design review is to ship it!

#4 @audrasjb
3 months ago

  • Keywords commit added

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


3 months ago

@helen
3 months ago

After patch, no updates available

#6 @helen
3 months ago

I attached a screenshot with this patch when no updates are available, just for reference. I think it does still look better to not have two secondary buttons, perhaps especially without a primary button present.

I also traced back through history and this was always a button, so no need to worry that we're undoing a previous decision to make this a button. Will handle commit momentarily.

#7 @helen
3 months ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 49150:

Updates: Reduce secondary buttons for less visual complexity.

Props audrasjb, karmatosed.
Fixes #51523.

#8 @afercia
3 months ago

Totally in favor of making "Check Again" look like a link. Just a quick question: since this is now a link that looks like a link, does it still make sense to use title case? A textual link using title case seems a bit odd to me. I'd tend to think it should now use sentence case. Maybe also consider to add a period after the link.

#9 @SergeyBiryukov
3 months ago

In 49471:

Upgrade/Install: Switch "Check again" link on WordPress Updates screen to sentence case.

This brings some consistency with other text links on the screen, e.g. "View version details" for plugins or themes.

Follow-up to [49150].

Props afercia.
See #51523.

Note: See TracTickets for help on using tickets.