WordPress.org

Make WordPress Core

Opened 6 weeks ago

Closed 4 weeks ago

Last modified 4 weeks ago

#51524 closed defect (bug) (fixed)

"There has been a critical error on your website" should be changed to "There has been a critical error on this website"

Reported by: techboyg5 Owned by: desrosj
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: Site Health Keywords: has-patch commit
Focuses: ui-copy Cc:

Description

"There is a critical error in your website" is the current message when a PHP error occurs in WordPress.

But if the website is not your own, then this message does not make sense.

I think it should be changed to "There is a critical error in this website", which makes sense no matter who accesses the website.

Attachments (3)

Capture d’écran 2020-10-15 à 00.44.15.png (66.1 KB) - added by audrasjb 6 weeks ago.
Before
Capture d’écran 2020-10-15 à 00.50.07.png (66.1 KB) - added by audrasjb 6 weeks ago.
After patch
51524.diff (672 bytes) - added by audrasjb 6 weeks ago.
Site Health: Replace "your website" with "this website" on visitor facing errors

Download all attachments as: .zip

Change History (15)

This ticket was mentioned in PR #600 on WordPress/wordpress-develop by techboyg5.


6 weeks ago

  • Keywords has-patch added

#3 @SergeyBiryukov
6 weeks ago

  • Component changed from General to Site Health

#4 @audrasjb
6 weeks ago

  • Focuses ui-copy added
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 5.6
  • Owner set to audrasjb
  • Status changed from new to accepted
  • Version 5.5.1 deleted

Hi,

Good point. I think we definitely need to address this issue.
I tested the patch and it looks good to me. Adding to milestone 5.6.

#5 @audrasjb
6 weeks ago

  • Keywords dev-feedback added

In 51524.diff, I replaced the sting only for visitor-facing errors.
Indeed we don't need to replace "your" when we are under Recovery mode or is_protected_endpoint() contexts.

Last edited 6 weeks ago by audrasjb (previous) (diff)

@audrasjb
6 weeks ago

Site Health: Replace "your website" with "this website" on visitor facing errors

#6 @techboyg5
6 weeks ago

  • Summary changed from "There is a critical error in your website" should be changed to "There is a critical error in this website" to "There has been a critical error on your website" should be changed to "There has been a critical error on this website"

#7 @Clorith
6 weeks ago

I actually think it makes sense to use this for all three scenarios, even non-public pages, it may still not be your site, for example the user logging in may just be managing it for a client.

So with that I think pr600 makes sense to use.

#8 @hellofromTonya
4 weeks ago

  • Keywords dev-feedback removed

@audrasjb do you agree that we can move forward with PR600? If yes, can we mark this one commit?

#9 @audrasjb
4 weeks ago

  • Keywords commit added

Yes, @Clorith is right. Marking this for commit (PR600).

#10 @desrosj
4 weeks ago

  • Owner changed from audrasjb to desrosj
  • Status changed from accepted to assigned

#11 @helen
4 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 49480:

Site Health: Site errors are for *this* site, not necessarily *your* site.

Props techboyg5, Clorith, audrasjb.
Fixes #51524.

Note: See TracTickets for help on using tickets.