#51524 closed defect (bug) (fixed)
"There has been a critical error on your website" should be changed to "There has been a critical error on this website"
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Site Health | Keywords: | has-patch commit |
Focuses: | ui-copy | Cc: |
Description
"There is a critical error in your website" is the current message when a PHP error occurs in WordPress.
But if the website is not your own, then this message does not make sense.
I think it should be changed to "There is a critical error in this website", which makes sense no matter who accesses the website.
Attachments (3)
Change History (15)
This ticket was mentioned in PR #600 on WordPress/wordpress-develop by techboyg5.
3 years ago
#1
- Keywords has-patch added
#4
@
3 years ago
- Focuses ui-copy added
- Keywords has-patch added
- Milestone changed from Awaiting Review to 5.6
- Owner set to audrasjb
- Status changed from new to accepted
- Version 5.5.1 deleted
Hi,
Good point. I think we definitely need to address this issue.
I tested the patch and it looks good to me. Adding to milestone 5.6.
#5
@
3 years ago
- Keywords dev-feedback added
In 51524.diff
, I replaced the sting only for visitor-facing errors.
Indeed we don't need to replace "your" when we are under Recovery mode or is_protected_endpoint()
contexts.
#6
@
3 years ago
- Summary changed from "There is a critical error in your website" should be changed to "There is a critical error in this website" to "There has been a critical error on your website" should be changed to "There has been a critical error on this website"
#7
@
3 years ago
I actually think it makes sense to use this
for all three scenarios, even non-public pages, it may still not be your site, for example the user logging in may just be managing it for a client.
So with that I think pr600 makes sense to use.
#8
@
3 years ago
- Keywords dev-feedback removed
@audrasjb do you agree that we can move forward with PR600? If yes, can we mark this one commit
?
Trac ticket: https://core.trac.wordpress.org/ticket/51524