"There has been a critical error on your website" should be changed to "There has been a critical error on this website"

[techboyg5]

"There is a critical error in your website" is the current message when a PHP error occurs in WordPress.

But if the website is not your own, then this message does not make sense.

I think it should be changed to "There is a critical error in this website", which makes sense no matter who accesses the website.

Trac ticket: https://core.trac.wordpress.org/ticket/51524

[techboyg5]

​https://github.com/WordPress/wordpress-develop/pull/600

[audrasjb]

Hi,

Good point. I think we definitely need to address this issue.
I tested the patch and it looks good to me. Adding to milestone 5.6.

[audrasjb]

Before

[audrasjb]

After patch

[audrasjb]

In 51524.diff, I replaced the sting only for visitor-facing errors.
Indeed we don't need to replace "your" when we are under Recovery mode or is_protected_endpoint() contexts.

[audrasjb]

Site Health: Replace "your website" with "this website" on visitor facing errors

[Clorith]

I actually think it makes sense to use this for all three scenarios, even non-public pages, it may still not be your site, for example the user logging in may just be managing it for a client.

So with that I think pr600 makes sense to use.

[hellofromTonya]

@audrasjb do you agree that we can move forward with ​PR600? If yes, can we mark this one commit?

[audrasjb]

Yes, @Clorith is right. Marking this for commit (PR600).

[helen]

In 49480:

Site Health: Site errors are for *this* site, not necessarily *your* site.

Props techboyg5, Clorith, audrasjb.
Fixes #51524.

Committed in ​https://github.com/WordPress/wordpress-develop/commit/85abd2fc8b41298bcea44d53c6e8c29e92274950