WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#51531 closed enhancement (fixed)

Expose 'embed' core block in WordPress core

Reported by: ntsekouras Owned by: SergeyBiryukov
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch commit
Focuses: Cc:

Description

With the refactoring of embed blocks to use a single block with many block variations, embed block should be exposed in the server as well.

Change History (9)

#1 @youknowriad
3 months ago

  • Milestone changed from Awaiting Review to 5.6

This ticket was mentioned in ​PR #605 on ​WordPress/wordpress-develop by ​ntsekouras.
3 months ago

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/51531

#3 @prbot
3 months ago

​gziolo commented on ​PR #605:

I checked #373 to see what is necessary. We still need to ensure that block.json for Embed block is copied over from the npm package. There is no embed folder at the moment:

​https://github.com/WordPress/wordpress-develop/tree/master/src/wp-includes/blocks

Running npm run build or npm run build:dev should do the trick. It might work for either of those two, I don't remember.

#4 @prbot
3 months ago

​gziolo commented on ​PR #605:

It looks great now 👍

This ticket was mentioned in ​Slack in #core by hellofromtonya. ​View the logs.
3 months ago

#6 @SergeyBiryukov
3 months ago

  • Keywords commit added

#7 @SergeyBiryukov
3 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#8 @SergeyBiryukov
3 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 49210:

Editor: Expose the embed core block on the server.

Props ntsekouras, gziolo.
Fixes #51531.

Note: See TracTickets for help on using tickets.