WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#51531 closed enhancement (fixed)

Expose 'embed' core block in WordPress core

Reported by: ntsekouras's profile ntsekouras Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch commit
Focuses: Cc:

Description

With the refactoring of embed blocks to use a single block with many block variations, embed block should be exposed in the server as well.

Change History (9)

#1 @youknowriad
4 years ago

  • Milestone changed from Awaiting Review to 5.6

This ticket was mentioned in ​PR #605 on ​WordPress/wordpress-develop by ​ntsekouras.
4 years ago #2

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/51531

​gziolo commented on ​PR #605:
4 years ago #3

I checked #373 to see what is necessary. We still need to ensure that block.json for Embed block is copied over from the npm package. There is no embed folder at the moment:

​https://github.com/WordPress/wordpress-develop/tree/master/src/wp-includes/blocks

Running npm run build or npm run build:dev should do the trick. It might work for either of those two, I don't remember.

​gziolo commented on ​PR #605:
4 years ago #4

It looks great now 👍

This ticket was mentioned in ​Slack in #core by hellofromtonya. ​View the logs.
4 years ago

#6 @SergeyBiryukov
4 years ago

  • Keywords commit added

#7 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#8 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 49210:

Editor: Expose the embed core block on the server.

Props ntsekouras, gziolo.
Fixes #51531.

Note: See TracTickets for help on using tickets.