WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#51533 closed defect (bug) (fixed)

Remove the additional space in the comment date link

Reported by: poena Owned by: SergeyBiryukov
Priority: normal Milestone: 5.6
Component: Comments Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

In class-walker-comment.php on line 436, in the comment metadata for the comment date, there is a space between </time> and </a> that is causing an extra space at the end of the link.

https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-walker-comment.php#L436

Attachments (2)

comment-date.png​ (15.2 KB ) - added by poena 6 years ago.
The extra space is visible at the end of the link
51533.patch​ (1.2 KB ) - added by mukesh27 6 years ago.
Patch that fixed the issue

Download all attachments as: .zip

Change History (9)

@poena
6 years ago

The extra space is visible at the end of the link

#1 @SergeyBiryukov
6 years ago

  • Milestone Awaiting Review → 5.6

@mukesh27
6 years ago

Patch that fixed the issue

#2 @mukesh27
6 years ago

  • Keywords has-patch added

#3 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Status new → reviewing

#4 @SergeyBiryukov
6 years ago

In 49157:

Comments: Remove extra space from the comment link in Walker_Comment.

Props poena, mukesh27, SergeyBiryukov.
See #51533.

#5 @SergeyBiryukov
6 years ago

In 49158:

Twenty Twenty: Remove extra space from the comment link in TwentyTwenty_Walker_Comment.

See #51533.

#6 @SergeyBiryukov
6 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 49159:

Twenty Nineteen: Remove extra space from the comment link in TwentyNineteen_Walker_Comment.

Fixes #51533.

#7 @SergeyBiryukov
6 years ago

In 49160:

Comments: Further remove unnecessary context switch in Walker_Comment.

Follow-up to [49157].

See #51533.

Note: See TracTickets for help on using tickets.