7 | | - There are a few name changes that we didn't love. For example, renaming `$item` to `$data_object` everywhere int eh affected code. It seems simpler to just assign `$item=$data_object;` at the beginning. This is something done in other instances already. |
8 | | - In some places the PR just assignes `$post = $item` at the beginning, in others it replaces everything with `$item`, which could make the code less clear. One location this is noticeable is within `class-wp-ms-themes-list-tablep.php`. The [https://github.com/WordPress/wordpress-develop/pull/612/files#diff-0dc5774897687f8570c4ae0af63be5074e83455f3382cca1db88ce9a05656554 first two methods rename the variable across the whole method, but the third one does not]. Would be great to have some consistency there. |
| 7 | - There are a few name changes that we didn't love. For example, renaming `$item` to `$data_object` everywhere int eh affected code. It seems simpler to just assign `$item = $data_object;` at the beginning. This is something done in other instances already. |
| 8 | - In some places the PR just assignes `$post = $item` at the beginning, in others it replaces everything with `$item`, which could make the code less clear. One location this is noticeable is within `class-wp-ms-themes-list-table.php`. The [https://github.com/WordPress/wordpress-develop/pull/612/files#diff-0dc5774897687f8570c4ae0af63be5074e83455f3382cca1db88ce9a05656554 first two methods rename the variable across the whole method, but the third one does not]. Would be great to have some consistency there. |