WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #51553, comment 15


Ignore:
Timestamp:
05/07/2021 12:55:05 PM (7 months ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #51553, comment 15

    v1 v2  
    55I was discussing with @SergeyBiryukov, and here are some notes from what we discussed:
    66
    7 - There are a few name changes that we didn't love. For example, renaming `$item` to `$data_object` everywhere int eh affected code. It seems simpler to just assign `$item = $data_object;` at the beginning. This is something done in other instances already.
     7- There are a few name changes that we didn't love. For example, renaming `$item` to `$data_object` everywhere in the affected code. It seems simpler to just assign `$item = $data_object;` at the beginning. This is something done in other instances already.
    88- In some places the PR just assignes `$post = $item` at the beginning, in others it replaces everything with `$item`, which could make the code less clear. One location this is noticeable is within `class-wp-ms-themes-list-table.php`. The [https://github.com/WordPress/wordpress-develop/pull/612/files#diff-0dc5774897687f8570c4ae0af63be5074e83455f3382cca1db88ce9a05656554 first two methods rename the variable across the whole method, but the third one does not]. Would be great to have some consistency there.
    99