WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

#51558 closed defect (bug) (fixed)

Fix "Only variables should be passed by reference" notice

Reported by: jrf Owned by: SergeyBiryukov
Milestone: 5.6 Priority: normal
Severity: minor Version: 5.6
Component: Feeds Keywords: has-patch commit
Focuses: coding-standards Cc:

Description

WP should not throw notices. But when atomlib.php is used, it would. See: https://3v4l.org/mCQ9d

While this is an external dependency, it is no longer maintained externally, so fixing this in the version in Core only.

There is no functional change.

Attachments (1)

51558.patch (1.1 KB) - added by jrf 3 months ago.

Download all attachments as: .zip

Change History (3)

@jrf
3 months ago

#2 @SergeyBiryukov
3 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 49182:

Feeds: Fix "Only variables should be passed by reference" PHP notice in atomlib.php.

Props jrf.
Fixes #51558.

Note: See TracTickets for help on using tickets.