WordPress.org

Make WordPress Core

Opened 3 months ago

Last modified 3 months ago

#51566 new defect (bug)

Process embeds for block widgets

Reported by: talldanwp Owned by:
Milestone: 5.7 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: needs-patch
Focuses: Cc:

Description

As noticed in a Gutenberg issue (https://github.com/WordPress/gutenberg/issues/26180), embeds made using the embed block are not showing on the front end.

From what I understand, the class WP_Embed is responsible for processing embeds in content.

Currently it runs on the_content (post content) and widget_text_content (text widgets), but not on other types of widget:
https://github.com/WordPress/wordpress-develop/blob/86fc3af215a61f042804e3feb57627976d2bb54d/src/wp-includes/class-wp-embed.php#L32-L40

To solve the bug, I think we'd want it to also run for all block based widgets.

Change History (3)

#1 @talldanwp
3 months ago

  • Milestone changed from Awaiting Review to 5.6

#2 @talldanwp
3 months ago

I think this is currently blocked awaiting https://github.com/WordPress/wordpress-develop/pull/603/files#diff-8d37f4aaee8cc3c4ae950d5fc9bdfada959506a7f5d4c71ba3a546651cc86394 (trac ticket - https://core.trac.wordpress.org/ticket/51506), which adds the WP_Widget_Block class to core from the gutenberg repository.

Once that's in place a filter could be added to that block widget, and then the same technique used to process embeds.

I haven't worked on core embed code before, so if I'm wrong in any of these assumptions, let me know :)

#3 @talldanwp
3 months ago

  • Milestone changed from 5.6 to 5.7

Bumping to 5.7 along with other widget related changes.

Note: See TracTickets for help on using tickets.