WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #51580, comment 47


Ignore:
Timestamp:
11/12/2020 03:32:49 PM (2 months ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #51580, comment 47

    initial v1  
    1111* Splitting `: not required to update profile` into a new string is not friendly for translators, this should be a single string with the full sentence for better context.
    1212* `esc_attr_e()` should be replaced with `_e()`, as the string is no longer in an attribute.
    13 * The same placeholder is also used in `wp-admin/authorize-application.php`, so removing it in this one instance would be inconsistent. There are also some placeholder in other areas of core, so I'm not sure whether that's an issue, as long as the associated field is properly described.
     13* The same placeholder is also used in `wp-admin/authorize-application.php`, so removing it in this one instance would be inconsistent. There are also some placeholders in other areas of core, so I'm not sure whether that's an issue, as long as the associated field is properly described.
    1414
    1515[attachment:"51580.diff"] corrects the `aria-describedby` attribute.