Make WordPress Core

Opened 3 months ago

Closed 3 months ago

#51581 closed defect (bug) (fixed)

App Passwords: Fix success=false not being appended to fallback reject url

Reported by: TimothyBlynJacobs Owned by: TimothyBlynJacobs
Milestone: 5.6 Priority: normal
Severity: normal Version: 5.6
Component: Login and Registration Keywords: has-patch
Focuses: rest-api Cc:


On the Authorize Application screen with a success_url of https://example.org, we display https://example.org?success=false as the rejection URL. However, the user is redirected to https://example.org, without success=false

Change History (7)

This ticket was mentioned in PR #637 on WordPress/wordpress-develop by TimothyBJacobs.

3 months ago

  • Keywords has-patch added

#2 @prbot
3 months ago

TimothyBJacobs commented on PR #637:

@georgestephanis if you could review that'd be great!

#3 @georgestephanis
3 months ago

Added some thoughts about a logic path that this change messes with -- if both the success url and reject urls are omitted, this enters an odd fail state.

#4 @georgestephanis
3 months ago

With the latest changes it looks right to me. Do we have any integration testing or the like for core we could build against for this? It seems like it may be tricky to mock for unit testing.

#5 @TimothyBlynJacobs
3 months ago

There is a project to add end-to-end tests in Core, but I don't think we've formally started yet. There is a more recent update than this, https://make.wordpress.org/core/2019/06/27/introducing-the-wordpress-e2e-tests/, but I can't find it atm. https://github.com/WordPress/wordpress-develop/tree/master/tests/e2e/specs

This ticket was mentioned in Slack in #core-passwords by georgestephanis. View the logs.

3 months ago

#7 @TimothyBlynJacobs
3 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 49272:

App Passwords: Fix success=false not being appended to fallback reject url.

Props TimothyBlynJacobs, georgestephanis.
Fixes #51581.

Note: See TracTickets for help on using tickets.