Missing whitespace between comment reply title and cancel comment reply link

[Guido07111975]

Hi,

There's a missing whitespace between the comment reply title and the cancel comment reply link.
This results in: "Reply to A WordPress CommenterCancel reply".

The cancel-comment-reply-link is wrapped in <small> tags.
In file comment-template there's a whitespace before the opening tag: 'cancel_reply_before' => ' <small>',
But somehow it's being ignored in comment form. Stripped perhaps? Was not able to find what causes this.

More info here:
​https://wordpress.org/support/topic/cancel-comment-reply-link-in-comments-form/.

[davidbaumwald]

@Guido07111975 Do you have anything in your theme/plugins hooking in to comment_form_defaults?

[Guido07111975]

Hi David,

No, don’t think so.
Please check for example the TwentyNineteen theme. TwentyTwenty has some margin-left added to the link, so no visual issue with that one.

Guido

[bcworkz]

The cancel reply link is placed within the title's before/after HTML, making it difficult to reorder elements with CSS as might be desired by some themes. The cancel reply link ought to be its own element outside of title HTML. In other words, move the echo $args['title_reply_after']; line up to before the echo $args['cancel_reply_before']; line.

Fix missing white space between comment reply title and cancel comment reply link.
Currently all themes use CSS to fix this.

There's a single white space added, but that's ignored: ' <small>'
When adding white space before ánd after the tag it will display properly: ' <small> '

As mentioned in this trac ticket.

[Guido07111975]

​https://github.com/WordPress/wordpress-develop/pull/8423

Fix missing white space between comment reply title and cancel comment reply link.
Currently all themes use CSS to fix this.

There's a single white space added, but that's ignored: ' <small>'
When adding white space before ánd after the tag it will display properly: ' <small> '

As mentioned in this trac ticket.

Closed PR because from wrong branch. Created new PR.

Revert previous commit and remove single white space before small tag, because it has no visible effect.
Maybe adding white space with CSS (such as now) instead of hard coded is sufficent?

Looks like wp_parse_args() strips white space ' ' but respects  .

Reverted last commit.
Removed white space before the small tag, because it's stripped. So it has no added value.
I did not find a fix for this. Currently all themes use CSS to fix this, so maybe just leave it at that..

Closed PR because I'm not able to fix this properly.