Make WordPress Core

Opened 5 years ago

Last modified 8 weeks ago

#51589 new defect (bug)

Missing whitespace between comment reply title and cancel comment reply link

Reported by: guido07111975's profile Guido07111975 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Comments Keywords: reporter-feedback has-patch
Focuses: Cc:

Description

Hi,

There's a missing whitespace between the comment reply title and the cancel comment reply link.
This results in: "Reply to A WordPress CommenterCancel reply".

The cancel-comment-reply-link is wrapped in <small> tags.
In file comment-template there's a whitespace before the opening tag: 'cancel_reply_before' => ' <small>',
But somehow it's being ignored in comment form. Stripped perhaps? Was not able to find what causes this.

More info here:
https://wordpress.org/support/topic/cancel-comment-reply-link-in-comments-form/.

Change History (7)

#1 @davidbaumwald
5 years ago

  • Keywords reporter-feedback added
  • Version 5.5.1 deleted

@Guido07111975 Do you have anything in your theme/plugins hooking in to comment_form_defaults?

#2 @Guido07111975
4 years ago

Hi David,

No, don’t think so.
Please check for example the TwentyNineteen theme. TwentyTwenty has some margin-left added to the link, so no visual issue with that one.

Guido

#3 @bcworkz
4 years ago

The cancel reply link is placed within the title's before/after HTML, making it difficult to reorder elements with CSS as might be desired by some themes. The cancel reply link ought to be its own element outside of title HTML. In other words, move the echo $args['title_reply_after']; line up to before the echo $args['cancel_reply_before']; line.

This ticket was mentioned in PR #8419 on WordPress/wordpress-develop by Guido07111975.


8 weeks ago
#4

  • Keywords has-patch added

Fix missing white space between comment reply title and cancel comment reply link.
Currently all themes use CSS to fix this.

There's a single white space added, but that's ignored: ' <small>'
When adding white space before ánd after the tag it will display properly: ' <small> '

As mentioned in this trac ticket.

https://github.com/user-attachments/assets/cbca27dd-5c20-4533-b059-dfae6216e9c0

This ticket was mentioned in PR #8423 on WordPress/wordpress-develop by Guido07111975.


8 weeks ago
#6

Fix missing white space between comment reply title and cancel comment reply link.
Currently all themes use CSS to fix this.

There's a single white space added, but that's ignored: ' <small>'
When adding white space before ánd after the tag it will display properly: ' <small> '

As mentioned in this trac ticket.

https://github.com/user-attachments/assets/cbca27dd-5c20-4533-b059-dfae6216e9c0

Guido07111975 commented on PR #8419:


8 weeks ago
#7

Closed PR because from wrong branch. Created new PR.

Note: See TracTickets for help on using tickets.