WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#51594 closed defect (bug) (fixed)

WP_PLUGIN_DIR constant unintentionally breaks plugin tests

Reported by: pierlo Owned by: SergeyBiryukov
Priority: high Milestone: 5.6
Component: Build/Test Tools Version: 5.6
Severity: major Keywords: has-patch has-unit-tests
Cc: Focuses:

Description (last modified by pierlo)

A ​recent change was made to the PHPUnit bootstrap file that sets WP_PLUGIN_DIR to the path of the plugin test data directory (tests/phpunit/data/plugins). This modification will unintentionally break a lot of tests for non-core plugins that rely on WP_PLUGIN_DIR being set to the expected plugins directory in WP_CONTENT_DIR or already have the constant defined.

Since the WP_PLUGIN_DIR constant is only needed when Core tests are to be run, I'd like to propose that the constant will only be set when WP_RUN_CORE_TESTS has a truthy value.

Change History (4)

This ticket was mentioned in ​PR #642 on ​WordPress/wordpress-develop by ​pierlon.
6 years ago #1

  • Keywords has-patch has-unit-tests added

Trac ticket: https://core.trac.wordpress.org/ticket/51594

#2 @pierlo
6 years ago

  • Description modified (diff)

#3 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 49269:

Build/Test Tools: Only define WP_PLUGIN_DIR in when running core tests.

This takes into account non-core plugins that rely on WP_PLUGIN_DIR being set to the expected plugin's directory in WP_CONTENT_DIR, or already have the constant defined.

Follow-up to [49236].

Props pierlo.
Fixes #51594.

Note: See TracTickets for help on using tickets.