WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 2 of Ticket #51594


Ignore:
Timestamp:
10/22/2020 12:26:48 AM (5 years ago)
Author:
pierlo
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #51594

    • Property Keywords has-patch has-unit-tests added

  • Ticket #51594 – Description

    initial v2  
    1 A [https://github.com/WordPress/wordpress-develop/pull/613/commits/5857216e7424053a6e588e7d2323874eab1f8529 recent change] was made to the PHPUnit bootstrap file that sets `WP_PLUGIN_DIR` to the path of the plugin test data directory (`tests/phpunit/data/plugins`). This modeification will unintentionally break a lot of tests for non-core plugins that rely on `WP_PLUGIN_DIR` being set to the expected plugins directory in `WP_CONTENT_DIR` or already have the constant defined.
     1A [https://github.com/WordPress/wordpress-develop/pull/613/commits/5857216e7424053a6e588e7d2323874eab1f8529 recent change] was made to the PHPUnit bootstrap file that sets `WP_PLUGIN_DIR` to the path of the plugin test data directory (`tests/phpunit/data/plugins`). This modification will unintentionally break a lot of tests for non-core plugins that rely on `WP_PLUGIN_DIR` being set to the expected plugins directory in `WP_CONTENT_DIR` or already have the constant defined.
    22
    33Since the `WP_PLUGIN_DIR` constant is only needed when Core tests are to be run, I'd like to propose that the constant will only be set when `WP_RUN_CORE_TESTS` has a truthy value.