WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#51618 closed defect (bug) (fixed)

Coding format for <div class="wrap"> in wp-admin/update-core.php

Reported by: ravipatel's profile ravipatel Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.6 Priority: normal
Severity: minor Version: 5.6
Component: Administration Keywords: has-patch
Focuses: coding-standards Cc:

Description

Continue sequence for a code format structure.

Attachments (1)

51618-update-core.php.patch​ (599 bytes) - added by ravipatel 4 years ago.
code standard - manage code format

Download all attachments as: .zip

Change History (3)

@ravipatel
4 years ago

code standard - manage code format

#1 @SergeyBiryukov
4 years ago

  • Component changed from General to Administration
  • Milestone changed from Awaiting Review to 5.6
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing
  • Summary changed from Codeing Format to Coding format for <div class="wrap"> in wp-admin/update-core.php

Hi there, thanks for the patch!

Looking at the other 51 instances of <div class="wrap"> in the admin files, the current structure appears to be more consistent with them.

However, there is indeed a discrepancy between "Update Plugins" and "Update Themes" sections in the same file, so let's fix that.

#2 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 49297:

Coding Standards: Use consistent formatting for <div class="wrap"> sections in wp-admin/update-core.php.

Follow-up to [28500], [28530].

Props ravipatel.
Fixes #51618.

Note: See TracTickets for help on using tickets.