WordPress.org

Make WordPress Core

Opened 5 weeks ago

Closed 5 weeks ago

Last modified 4 weeks ago

#51622 closed defect (bug) (fixed)

Invalid value for speak CSS property

Reported by: Hareesh Pillai Owned by: SergeyBiryukov
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:

Description

Follow up to #51587

Core has some CSS files that contain the speak CSS property with a value of none.

This is not a valid value for the speak CSS property. never is the correct value.

Attachments (1)

51622.diff (14.5 KB) - added by Hareesh Pillai 5 weeks ago.

Download all attachments as: .zip

Change History (5)

@Hareesh Pillai
5 weeks ago

#1 @SergeyBiryukov
5 weeks ago

  • Milestone changed from Awaiting Review to 5.6

#2 follow-up: @SergeyBiryukov
5 weeks ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

Thanks for the patch! It looks like there are some changes for external packages:

  • Thickbox: This appears to not be maintained upstream and had quite a few fixes in core over the years already, so should be fine to patch.
  • Genericons in Twenty Fifteen: This appears to be maintained at https://github.com/Automattic/Genericons, but there is no activity for the last four years, so it's probably OK to patch here. That said, a PR should be created for the same change upstream too.
  • Genericons in Twenty Sixteen: Same as above.
Last edited 5 weeks ago by SergeyBiryukov (previous) (diff)

#3 @SergeyBiryukov
5 weeks ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 49309:

General: Use correct value for the speak property in various CSS files.

Follow-up to [49263].

Props hareesh-pillai.
Fixes #51622.

#4 in reply to: ↑ 2 @SergeyBiryukov
4 weeks ago

Replying to SergeyBiryukov:

Genericons in Twenty Fifteen: This appears to be maintained at https://github.com/Automattic/Genericons, but there is no activity for the last four years, so it's probably OK to patch here. That said, a PR should be created for the same change upstream too.

For reference, this was done in https://github.com/Automattic/Genericons/pull/112. Thanks @hareesh-pillai!

Note: See TracTickets for help on using tickets.