Opened 4 years ago
Closed 4 years ago
#51624 closed defect (bug) (fixed)
Composer 2.0 Support
Reported by: | TimothyBlynJacobs | Owned by: | desrosj |
---|---|---|---|
Milestone: | 5.6 | Priority: | normal |
Severity: | normal | Version: | 5.6 |
Component: | Build/Test Tools | Keywords: | has-patch commit |
Focuses: | coding-standards | Cc: |
Description
GitHub actions is now using Composer 2.0 which was released earlier today. It looks like that is causing test failures due to a dependency of ours that isn't compatible.
Error: Your lock file does not contain a compatible set of packages. Please run composer update. Problem 1 - dealerdirect/phpcodesniffer-composer-installer is locked to version v0.6.2 and an update of this package was not requested. - dealerdirect/phpcodesniffer-composer-installer v0.6.2 requires composer-plugin-api ^1.0 -> found composer-plugin-api[2.0.0] but it does not match the constraint. You are using Composer 2, which some of your plugins seem to be incompatible with. Make sure you update your plugins or report a plugin-issue to ask them to support Composer 2.
Discussing in Slack, @jrf points out it looks like this can be fixed by updating our dependency to allow a newer version which does support Composer 2.0.
Change History (18)
This ticket was mentioned in PR #656 on WordPress/wordpress-develop by TimothyBJacobs.
4 years ago
#1
- Keywords has-patch added
#2
@
4 years ago
- Focuses coding-standards added
- Keywords commit added
Reviewed & this patch is ready to commit.
Context:
As this repo uses a committed composer.lock
file, this updated is needed to get the newer version of the plugin, but even if there wouldn't be a committed composer.lock
file, the composer.json
would still have needed to be updated as Composer treats minors below 1.0
as majors, so updated need to be done explicitly.
Relevant changelog of the dependency: https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases/tag/v0.7.0
TimothyBJacobs commented on PR #656:
4 years ago
#4
Fixed in 9eed4bc352c944ce75c3ff1615bc63b7162af88b.
This ticket was mentioned in Slack in #core by sergey. View the logs.
4 years ago
#10
@
4 years ago
It looks like WordPress 5.2 and older branches don't have any Travis jobs using Composer, so I guess they don't require any changes for now.
This ticket was mentioned in Slack in #core by sergey. View the logs.
4 years ago
This ticket was mentioned in Slack in #core by sergey. View the logs.
4 years ago
#13
@
4 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
In working on #48301, I discovered that this will need to be backported to 5.1 & 5.2. Though Composer is not called directly, It is invoked by the travis:js
task.
https://wordpress.slack.com/archives/C02RQBWTW/p1603566293205600?thread_ts=1603552988.204000&cid=C02RQBWTW
https://core.trac.wordpress.org/ticket/51624