WordPress.org

Make WordPress Core

Opened 6 weeks ago

Closed 4 weeks ago

#51626 closed defect (bug) (invalid)

Update option checkout shown for the plugin that does not have update package

Reported by: rajeshsingh520 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords:
Focuses: ui, administration Cc:

Description

Hi,

We have a plugin that is not hosted on the wordpress.org, so for that plugin we give update motification using wordpress hook

we have faced an issue recently, in the update notification, we send "package" as empty that make the message https://i.imgur.com/mkEifAH.png

"Automatic update is unavailable for this plugin." on the plugins page

but on the Dashboard > update page the plugin does get an checkbox, so user end up selecting it for update and then get the error message

normally if Auto update is not available for a plugin then we should hide this checkbox as well

https://i.imgur.com/QOoU88J.png

Attachments (2)

download (25).png (341.0 KB) - added by rajeshsingh520 6 weeks ago.
screenshots
download (24).png (112.5 KB) - added by rajeshsingh520 6 weeks ago.
screenshot

Download all attachments as: .zip

Change History (7)

@rajeshsingh520
6 weeks ago

screenshots

@rajeshsingh520
6 weeks ago

screenshot

#1 @SergeyBiryukov
6 weeks ago

  • Component changed from General to Upgrade/Install
  • Focuses ui administration added

This ticket was mentioned in Slack in #core-auto-updates by audrasjb. View the logs.


4 weeks ago

#3 @pbiron
4 weeks ago

Hi @rajeshsingh520.

Thank you for the report.

Without more details about how the Pro plugin is hooking into the WP Updates API, it's hard to know what is going here.

The first thing I would recommend is that you read https://make.wordpress.org/core/2020/07/30/recommended-usage-of-the-updates-api-to-support-the-auto-updates-ui-for-plugins-and-themes-in-wordpress-5-5/ and verify that you are following the recommendations for how to hook into the Updates API.

#4 @rajeshsingh520
4 weeks ago

Hi,

thanks adding no_update fixed the issue I did not know about that

#5 @SergeyBiryukov
4 weeks ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Thanks for the follow-up!

Note: See TracTickets for help on using tickets.