Inconsistent naming in JavaScript function

[ribaricplusplus]

This is my first ticket, sorry if I'm doing something wrong.

The name for a function parameter in the doc comment is not the same as the actual function parameter.

I know this is extremely trivial but I was reading through core source code and I figured submitting a fix would be worthwhile to get me comfortable with the contributing process.

[davidbaumwald]

Hi @ribaricplusplus and welcome to Core Trac! Great catch!

This goes back to this commit back in the 4.0 cycle. Interestingly, the docs directly above the method refer to the param as staticProps.

[SergeyBiryukov]

Thanks for the patch, this looks good :)

[ribaricplusplus]

Replying to davidbaumwald:

Hi @ribaricplusplus and welcome to Core Trac! Great catch!

This goes back to this commit back in the 4.0 cycle. Interestingly, the docs directly above the method refer to the param as staticProps.

Thank you for the help.

I appreciate the warm welcome :)

[SergeyBiryukov]

Just noting that [29450] only added the documentation, the function itself was added earlier in [19995].

[SergeyBiryukov]

In 49353:

Customize: Update parameter name in api.Class.extend().

This makes the name consistent with the documentation and the inherits() function signature.

Props ribaricplusplus, davidbaumwald.
Fixes #51652.