WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #51678, comment 20


Ignore:
Timestamp:
11/06/2020 01:23:56 PM (5 years ago)
Author:
peterfabian1000
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #51678, comment 20

    initial v1  
    55Part of it could be our fault and how we use translations strings, but I think more plugins will probably face the same issue.
    66
    7 I've tried to create a POC with WP_Textdomain_Registry caching also on locale-level, it's linked to GH now, I think. I've also tested how it performs and you can see the results in the same screenshot, first rectangle shows load times with the early exit within `is_readable`, the second one is the same POC code, but without the early exit.
     7I've tried to create a PR with a POC of WP_Textdomain_Registry caching also on locale-level, https://github.com/WordPress/wordpress-develop/pull/694.
     8
     9I've also tested how it performs and you can see the results in the same screenshot, first rectangle shows load times with the early exit within `is_readable`, the second one is the same POC code, but without the early exit.
    810
    911To have a more exact number, I also counted the calls to load_textdomain() and I got the following numbers on loading WC home: