WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 3 of Ticket #51678


Ignore:
Timestamp:
10/30/2020 02:05:22 PM (4 years ago)
Author:
hellofromTonya
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #51678

    • Property Component changed from General to I18N
    • Property Priority changed from normal to high
    • Property Version changed from to trunk
    • Property Milestone changed from Awaiting Review to 5.6
    • Property Keywords needs-testing added

  • Ticket #51678 – Description

    initial v3  
    1 In WooCommerce's internal autmated performance testing, we are seeing performance degradations in all paths where any plugin is loaded whose translation file is not present. Root cause seems to in #49236, where we added some changes and introduced WP_Textdomain_Registry to store text domains and their language directory paths.
     1In WooCommerce's internal automated performance testing, we are seeing performance degradations in all paths where any plugin is loaded whose translation file is not present. Root cause seems to in [https://core.trac.wordpress.org/changeset/49236 changeset 49236], where we added some changes and introduced WP_Textdomain_Registry to store text domains and their language directory paths.
    22
    33Looks like, if translation file is not present for a domain, we hit the [https://core.trac.wordpress.org/browser/trunk/src/wp-includes/l10n.php?rev=49236#L742 is_readable] on every l10n call. While cached internally, it seems like this call is still slow on many hosts and it will be good to add additional caching around it.