WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 6 months ago

Last modified 6 months ago

#51682 closed defect (bug) (fixed)

Match .nvmrc to node version in package.json and travis.yml

Reported by: whyisjake Owned by: whyisjake
Milestone: 5.7 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:

Description

On several older versions of WordPress, the .nvmrc file is listing an incorrect version number. These should be updated to use the version that Travis is using when putting together builds.

Attachments (2)

nvmrc-4.9.diff (164 bytes) - added by whyisjake 6 months ago.
nvmrc-3.7.diff (165 bytes) - added by whyisjake 6 months ago.

Download all attachments as: .zip

Change History (21)

@whyisjake
6 months ago

@whyisjake
6 months ago

This ticket was mentioned in Slack in #core by whyisjake. View the logs.


6 months ago

#3 @desrosj
6 months ago

Also previously: #51603.

Related: #51749.

This ticket was mentioned in Slack in #core by whyisjake. View the logs.


6 months ago

#5 @whyisjake
6 months ago

  • Owner set to whyisjake
  • Resolution set to fixed
  • Status changed from assigned to closed

In 49653:

Build/Test Tools: Match .nvmrc with the declared node engine.

Let's match up the versions from package.json, .travis.yml and .nvmrc.

This is the commit for the 4.9 branch.

Fixes #51682.

Props SergeyBiryukov, desrosj, whyisjake.

#6 @whyisjake
6 months ago

In 49654:

Build/Test Tools: Match .nvmrc with the declared node engine.

Let's match up the versions from package.json, .travis.yml and .nvmrc.

This brings the changes from [49653] to the 4.8 branch.

Fixes #51682.

Props SergeyBiryukov, desrosj, whyisjake.

#7 @whyisjake
6 months ago

In 49655:

Build/Test Tools: Match .nvmrc with the declared node engine.

Let's match up the versions from package.json, .travis.yml and .nvmrc.

This brings the changes from [49653] to the 4.7 branch.

Fixes #51682.

Props SergeyBiryukov, desrosj, whyisjake.

#8 @whyisjake
6 months ago

In 49656:

Build/Test Tools: Match .nvmrc with the declared node engine.

Let's match up the versions from package.json, .travis.yml and .nvmrc.

This brings the changes from [49653] to the 4.6 branch.

Fixes #51682.

Props SergeyBiryukov, desrosj, whyisjake.

#9 @whyisjake
6 months ago

In 49657:

Build/Test Tools: Match .nvmrc with the declared node engine.

Let's match up the versions from package.json, .travis.yml and .nvmrc.

This brings the changes from [49653] to the 4.5 branch.

Fixes #51682.

Props SergeyBiryukov, desrosj, whyisjake.

#10 @whyisjake
6 months ago

In 49658:

Build/Test Tools: Match .nvmrc with the declared node engine.

Let's match up the versions from package.json, .travis.yml and .nvmrc.

This brings the changes from [49653] to the 4.5 branch.

Fixes #51682.

#11 @whyisjake
6 months ago

In 49659:

Build/Test Tools: Match .nvmrc with the declared node engine.

Let's match up the versions from package.json, .travis.yml and .nvmrc.

This brings the changes from [49653] to the 4.4 branch.

Fixes #51682.

#12 @whyisjake
6 months ago

In 49660:

Build/Test Tools: Match .nvmrc with the declared node engine.

Let's match up the versions from package.json, .travis.yml and .nvmrc.

This brings the changes from [49653] to the 4.3 branch.

Fixes #51682.

#13 @whyisjake
6 months ago

In 49661:

Build/Test Tools: Match .nvmrc with the declared node engine.

Let's match up the versions from package.json, .travis.yml and .nvmrc.

This brings the changes from [49653] to the 4.1 branch.

Fixes #51682.

#14 @whyisjake
6 months ago

In 49662:

Build/Test Tools: Match .nvmrc with the declared node engine.

Let's match up the versions from package.json, .travis.yml and .nvmrc.

This brings the changes from [49653] to the 4.0 branch.

Fixes #51682.

#15 @whyisjake
6 months ago

In 49663:

Build/Test Tools: Match .nvmrc with the declared node engine.

Let's match up the versions from package.json, .travis.yml and .nvmrc.

This brings the changes from [49653] to the 3.9 branch.

Fixes #51682.

#16 @whyisjake
6 months ago

In 49664:

Build/Test Tools: Match .nvmrc with the declared node engine.

Let's match up the versions from package.json, .travis.yml and .nvmrc.

This brings the changes from [49653] to the 3.8 branch.

Fixes #51682.

#17 @whyisjake
6 months ago

In 49665:

Build/Test Tools: Match .nvmrc with the declared node engine.

Let's match up the versions from package.json, .travis.yml and .nvmrc.

This brings the changes from [49653] to the 3.7 branch.

Fixes #51682.

#18 @whyisjake
6 months ago

In 49666:

Build/Test Tools: Match .nvmrc with the declared node engine.

Let's match up the versions from package.json, .travis.yml and .nvmrc.

This brings the changes from [49653] to the 4.2 branch.

Fixes #51682.

#19 @SergeyBiryukov
6 months ago

  • Milestone changed from Future Release to 5.7
Note: See TracTickets for help on using tickets.