WordPress.org

Make WordPress Core

Opened 3 weeks ago

Last modified 9 days ago

#51706 accepted defect (bug)

Menu Navigation css Media Query - Firefox

Reported by: ravipatel Owned by: sabernhardt
Milestone: 5.7 Priority: normal
Severity: normal Version:
Component: Menus Keywords: has-patch needs-refresh
Focuses: accessibility, css, administration Cc:

Description

https://prnt.sc/vdimjw

Please review this issue which is related to menu media query css.
I ma using firefox-win10.

Attachments (2)

51706-nav-menus.css.patch (339 bytes) - added by ravipatel 3 weeks ago.
51706-nav-menus.css-1.patch (368 bytes) - added by ravipatel 3 weeks ago.
As per comment added new patch. with removed this css.

Download all attachments as: .zip

Change History (6)

This ticket was mentioned in Slack in #core-css by ravi. View the logs.


3 weeks ago

#2 @sabernhardt
3 weeks ago

  • Focuses accessibility added
  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to 5.7
  • Owner set to sabernhardt
  • Status changed from new to accepted
  • Version trunk deleted

Thanks @ravipatel for the ticket and patch!

I see it in Firefox/Windows as well, but not with other Windows browsers (Chrome, Edge, IE). I verified that in both trunk and 5.4.

That zero top margin was added in [38912], so the cutoff could have occurred as early as 4.7. If there is no need to keep that margin at zero, I'd recommend removing the entire selector from the mobile styles instead of re-defining the margin at 4px.

Last edited 3 weeks ago by sabernhardt (previous) (diff)

@ravipatel
3 weeks ago

As per comment added new patch. with removed this css.

This ticket was mentioned in Slack in #core-css by ravi. View the logs.


3 weeks ago

This ticket was mentioned in Slack in #core-css by kirstyburgoine. View the logs.


9 days ago

Note: See TracTickets for help on using tickets.