Menu Navigation css Media Query - Firefox

[ravipatel]

​https://prnt.sc/vdimjw

Please review this issue which is related to menu media query css.
I ma using firefox-win10.

[sabernhardt]

Thanks @ravipatel for the ticket and patch!

I see it in Firefox/Windows as well, but not with other Windows browsers (Chrome, Edge, IE).

That zero top margin was added in [38912], so the cutoff could have occurred as early as 4.7. If there is no need to keep that margin at zero, I'd recommend removing the entire selector from the mobile styles instead of re-defining the margin at 4px.

[ravipatel]

As per comment added new patch. with removed this css.

[sabernhardt]

before the patch, with one checkbox in focus

[sabernhardt]

after the patch, with one checkbox in focus, showing 4 more pixels between the legend text and the first checkbox item

[sabernhardt]

@ravipatel Thanks for updating the patch!

It fixes the Firefox issue with the first checkbox's top border.

After looking at ticket:49245#comment:3, though, I think removing the overflow: hidden is a better method than changing the margins. If the overflow is not clipped, the full focus ring should show on the left side (as well as the top).

If you would like to join the conversation and/or test patches there, that would help bring both of these tickets to a resolution (and you would receive props for that, too).

[sabernhardt]

#52058 was marked as a duplicate.

[SergeyBiryukov]

In 49964:

Menus: Fix minor UI issues on Edit Menus screen on smaller viewports.

This removes extra margin from the Select button and ensures the checkboxes in the Menu Settings section are fully visible.

Props sabernhardt, passoniate, mukesh27, afercia, audrasjb, Boniu91, ravipatel, jomisica.
Fixes #49245, #51706.