Opened 4 years ago
Closed 4 years ago
#51706 closed defect (bug) (fixed)
Menu Navigation css Media Query - Firefox
Reported by: | ravipatel | Owned by: | sabernhardt |
---|---|---|---|
Milestone: | 5.7 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Menus | Keywords: | has-patch |
Focuses: | accessibility, css, administration | Cc: |
Description
Please review this issue which is related to menu media query css.
I ma using firefox-win10.
Attachments (4)
Change History (11)
This ticket was mentioned in Slack in #core-css by ravi. View the logs.
4 years ago
#2
@
4 years ago
- Focuses accessibility added
- Keywords needs-refresh added
- Milestone changed from Awaiting Review to 5.7
- Owner set to sabernhardt
- Status changed from new to accepted
- Version trunk deleted
This ticket was mentioned in Slack in #core-css by ravi. View the logs.
4 years ago
This ticket was mentioned in Slack in #core-css by kirstyburgoine. View the logs.
4 years ago
@
4 years ago
after the patch, with one checkbox in focus, showing 4 more pixels between the legend text and the first checkbox item
#5
@
4 years ago
- Keywords needs-refresh removed
@ravipatel Thanks for updating the patch!
It fixes the Firefox issue with the first checkbox's top border.
After looking at ticket:49245#comment:3, though, I think removing the overflow: hidden
is a better method than changing the margins. If the overflow is not clipped, the full focus ring should show on the left side (as well as the top).
If you would like to join the conversation and/or test patches there, that would help bring both of these tickets to a resolution (and you would receive props for that, too).
Thanks @ravipatel for the ticket and patch!
I see it in Firefox/Windows as well, but not with other Windows browsers (Chrome, Edge, IE). I verified that in both trunk and 5.4.
That zero top margin was added in [38912], so the cutoff could have occurred as early as 4.7. If there is no need to keep that margin at zero, I'd recommend removing the entire selector from the mobile styles instead of re-defining the margin at 4px.