WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 3 months ago

#51707 closed enhancement (fixed)

Add white-space as an allowed kses CSS attribute.

Reported by: whyisjake's profile whyisjake Owned by: davidbaumwald's profile davidbaumwald
Milestone: 6.9 Priority: normal
Severity: normal Version: 5.3.1
Component: Formatting Keywords: has-patch has-unit-tests commit
Focuses: Cc:

Description

white-space has wide ​browser support, and users would benefit from not having it stripped while adding to posts.

/wp-includes/kses.php:2177

Attachments (2)

51707.diff​ (329 bytes) - added by whyisjake 5 years ago.
51707.patch​ (694 bytes) - added by mukesh27 5 years ago.
Added doc for "white-space"

Download all attachments as: .zip

Change History (11)

@whyisjake
5 years ago

#1 @mukesh27
5 years ago

  • Keywords has-patch added; needs-patch removed

Patch 51707.diff​ looks fine for me and white-space support in all latest browser as per ​https://developer.mozilla.org/en-US/docs/Web/CSS/white-space article.

@mukesh27
5 years ago

Added doc for "white-space"

#2 @hellofromTonya
5 years ago

  • Version changed from trunk to 5.3.1

#3 @sabernhardt
4 months ago

  • Keywords needs-refresh added

This ticket was mentioned in ​PR #9197 on ​WordPress/wordpress-develop by ​@sukhendu2002.
4 months ago #4

  • Keywords has-unit-tests added; needs-refresh removed

Trac ticket: https://core.trac.wordpress.org/ticket/51707

#5 @sabernhardt
4 months ago

  • Milestone changed from Future Release to 6.9

​@mukesh27 commented on ​PR #9197:
4 months ago #6

Thanks @Sukhendu2002 picking and refreshing the patch!

#7 @maxinacube
3 months ago

This looks good to move forward.

Tested in playground environment by adding an inline style of white-space: nowrap|pre|etc.

On save, the style attribute persists as expected.

#8 @davidbaumwald
3 months ago

  • Keywords commit added
  • Owner set to davidbaumwald
  • Status changed from new to reviewing

#9 @TimothyBlynJacobs
3 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 60671:

Formatting: Add 'white-space' as an allowed KSES CSS attribute.

The 'white-space' attribute is safe, has wide browser support, and is useful.

Props sukhendu2002, mukesh27, whyisjake..
Fixes #51707.

Note: See TracTickets for help on using tickets.