Add parameters to "tag_cloud()" to bypass size variation, and to show frequency counts

[brh]

I wanted to display a "tag cloud" using the tag_cloud() tag, but without any inline font-size tags, and with the frequency of the tag displayed beside the tag (like it can be with categories). You can see an example at ​http://brh.numbera.com/blog/. To do this I added the "varysize" and "showcounts" parameters to the tag.

[brh]

Patch against trunk (rev. 6206) to add these two parameters

[westi]

Accepting Ticket - I will review this and checkin.

[westi]

Note to self - See also #5131 and #5172

[Otto42]

I think the whole tag cloud function might need a rethink here. This is the first tag cloud function I've seen using inline styles instead of simply assigning weight and ID classes. Inline styles are generally bad form, and move presentation out of the theme and into the core, which is the wrong way to go.

I propose getting rid of the inline styles entirely, and adding some styles to the bundled themes, so as to show how it's done. I suggest tag-cloud-weight-X and tag-cloud-id-X classes.

Yeah, it'll break some things. So deprecate for a version if you feel it's needed, but 2.4 should clean this up a bit and ditch the style="whatever" entirely from the tag cloud.

[AaronCampbell]

+1 for the inline styles being a bad idea

[brh]

Any chance this could get fixed for 2.8 or 2.7.1? I was disappointed to see that the inline styles are still there in 2.7.

[FFEMTcJ]

Replying to brh:

Any chance this could get fixed for 2.8 or 2.7.1? I was disappointed to see that the inline styles are still there in 2.7.

Is the patch still valid?

[Denis-de-Bernardy]

broken patch

[Denis-de-Bernardy]

see #5172