Adding classes to wp_generate_tag_cloud

[chmac]

The attached patch changes 2 things on the wp_generate_tag_cloud function.

1) The current code uses single quotes instead of double quotes, I believe the standard is to use double quotes. I've converted single quotes to double quotes.

2) I've rounded the tag size to a whole number (no decimal places).

3) I've added a class "tag-cloud-item-X" where X is the number in the list and a second class "tag-cloud-size-X" where X is the size of the tag. . This will allow theme designers to apply different styles to tags. For example changing the colour from cold to hot depending on order or size.

[markjaquith]

There is no standard for quotes style in XHTML. We tend to use doublequotes by default, but we'll use singlequotes if we want to concat in some variables.

e.g.

echo "<a href='$url'>$title</a>";

rather than:

echo '<a href="'. $url . '">' . $title . '</a>';

[westi]

+1 Good plan to add more classes for styling.

Relates to #5131 and #5171 all tag cloud changes.

I will get these all in soon.

[AaronCampbell]

+1 for adding some classes

I think we should actually remove the inline styles (font-size) and use classes instead.
Also, while we're adding classes, I think we should add a current_tag class if you're viewing a tag page.

[Denis-de-Bernardy]

see #5031 (with a broken patch)

[hakre]

see #8903 with some general suggestion on how to solve.

[hakre]

I take my comment over from #8903 for further reference:

• add new function wp_generate_tag_cloud_array() that takes care of data only
• that data should handle the absolute weight (min-max) as well as relative (1-5)
• use the new function on your own will
• update wp_genereate_tag_cloud() to use the new function as well.

going that route will seperate the concerns and refactor wp_generate_tag_cloud() a bit.

[hakre]

Are patches (or updates to the existing one) welcome for this issue?

[Mte90]

New patch updated

[Mte90]

Attached a new patch with code updated for last version of WordPress.

[Mte90]

any news for that patch?

[samuelsidler]

@boonebgorges: Want to take a look at this? :)

[boonebgorges]

The idea behind classes suggested in the patch looks good to me, but the patch needs a refresh after [32996].

'tag-cloud-item-' . count( $a ) feels like a weird class name. The integer doesn't describe the item, it describes the cardinal position (1, 2, 3...) of the tag in the cloud. How about 'tag-cloud-item-position-'?

[Mte90]

refreshed and changed name of the class to tag-link-position-

[Mte90]

I've refreshed the patch and changed the class name to tag-link-position- to be similar to the class used in the tag cloud.

[boonebgorges]

In 35984:

Introduce 'tag-link-position-x' class to tag cloud links.

The new class describes the cardinal position of a link in the cloud, allowing
more fine-grained CSS and JS targeting.

Props Mte90, chmac.
Fixes #5172.