REST:API One of the new strings should use _n()

[tobifjellner]

New string located in ​https://build.trac.wordpress.org/browser/trunk/wp-includes/rest-api.php?marks=2090#L2090

%1$s must contain at least %2$s properties.

Since %2$s is a number, this string should enable correct plural handling, using _n()

[audrasjb]

REST API: replace () with _n()

[TimothyBlynJacobs]

Thanks for catching that @tobifjellner! I think the PHPCS of the patch is incorrect though, @audrasjb.

[SergeyBiryukov]

Some notes on the patch:

• Translator comment should be directly above the line with the _n() call, not earlier.
• _n() should receive the number as is, number_format_i18n() is only needed in the second instance.
• As noted above, needs some PHPCS corrections.

Looks good otherwise :) This can all be corrected on commit.

[SergeyBiryukov]

These two strings also need the same adjustment:

if ( isset( $args['minItems'] ) && count( $value ) < $args['minItems'] ) {
	/* translators: 1: Parameter, 2: Number. */
	return new WP_Error( 'rest_invalid_param', sprintf( __( '%1$s must contain at least %2$s items.' ), $param, number_format_i18n( $args['minItems'] ) ) );
}

if ( isset( $args['maxItems'] ) && count( $value ) > $args['maxItems'] ) {
	/* translators: 1: Parameter, 2: Number. */
	return new WP_Error( 'rest_invalid_param', sprintf( __( '%1$s must contain at most %2$s items.' ), $param, number_format_i18n( $args['maxItems'] ) ) );
}

[SergeyBiryukov]

In 49536:

REST API: Use _n() in some error messages for proper plural forms support.

Follow-up to [47923], [49053].

Props audrasjb, tobifjellner, TimothyBlynJacobs, SergeyBiryukov.
Fixes #51727.