Make WordPress Core

Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#5173 closed enhancement (fixed)

Replace get_category_rss_link with get_category_feed_link

Reported by: ionfish's profile ionfish Owned by:
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.3
Component: Template Keywords: needs-patch
Focuses: Cc:


Replacing get_category_rss_link with a get_category_feed_link function would allow theme authors to use WordPress's Atom feeds instead, if they prefer. get_category_rss_link would be deprecated, but not removed, to keep backwards compatibility with themes which use it.

Attachments (1)

getcatfeedlink.diff (1.4 KB) - added by ionfish 17 years ago.

Download all attachments as: .zip

Change History (10)

#1 @foolswisdom
17 years ago

  • Keywords has-patch added
  • Milestone set to 2.4

#2 @markjaquith
17 years ago

  • Keywords needs-patch added; has-patch removed

+1 on the idea. But the patch only addresses default permalinks. People with pretty permalinks wouldn't get the feed type they asked for.

#3 @ionfish
17 years ago

Good point. I'll tweak the patch. I was also thinking of doing the same for get_author_rss_link, should I add that to this ticket or make a new one?

#4 @ryan
17 years ago

Look at get_tag_feed_link() and pattern get_category_feed_link() after it. We don't really need to pass the nicename and echo.

#5 @ionfish
17 years ago

More like it? :)

#6 @markjaquith
17 years ago

Getting better. On line 150, you need to trailingslashit($link) (like on the old line 138). Otherwise, you could get:

#7 @ionfish
17 years ago

Any chance of another look-over?

#8 @ryan
17 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6327]) get_category_feed_link() from ionfish. fixes #5173

#9 @ryan
17 years ago

(In [6328]) phpdoc for get_category_feed_link(). see #5173

Note: See TracTickets for help on using tickets.