WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #51742, comment 47


Ignore:
Timestamp:
11/13/2020 11:38:15 AM (14 months ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #51742, comment 47

    initial v1  
    22> `51742.10.diff` fixes this issue.
    33
    4 Just a quick note that in [49592] I changed the value passed to the filter from `null` to `false`, for consistency with the corresponding [source:tags/5.5.3/src/wp-admin/includes/class-wp-site-health-auto-updates.php?marks=152,153#L144 Site Health check].
     4Just a quick note that in [49592] I changed the value passed to the filter from `null` to `false`, for consistency with the corresponding [source:tags/5.5.3/src/wp-admin/includes/class-wp-site-health-auto-updates.php?marks=152,153#L144 Site Health check] and the [source:tags/5.5.3/src/wp-admin/includes/class-wp-automatic-updater.php?marks=53#L43 documented type of 'bool'].
    55
    66I know we pass `null` to the `auto_update_{$type}` filter to detect whether nothing has hooked into it, as discussed in #50848, but in this case it looks like we just need to detect whether the updater is disabled or not, so passing `false` seems appropriate.