WordPress.org

Make WordPress Core

Opened 3 weeks ago

Closed 10 days ago

#51743 closed task (blessed) (fixed)

Core auto-updates UI: Consider setting it by default for new installations

Reported by: audrasjb Owned by:
Milestone: 5.6 Priority: normal
Severity: normal Version: 5.6
Component: Upgrade/Install Keywords: has-patch has-screenshots
Focuses: Cc:

Description

During the last dev chat, setting major auto-updates by default for new installations was considered by the core team. The project leads also wanted to explore this for WP 5.6.

Attachments (5)

51743.diff (482 bytes) - added by audrasjb 3 weeks ago.
Upgrade/Install: set auto_update_core_major option to true for new installations
Capture d’écran 2020-11-10 à 01.35.57.png (228.0 KB) - added by audrasjb 3 weeks ago.
Patch works fine.
51743.2.diff (1.3 KB) - added by azaozz 2 weeks ago.
51743.3.diff (1.5 KB) - added by azaozz 2 weeks ago.
51743.4.diff (1.3 KB) - added by helen 2 weeks ago.

Download all attachments as: .zip

Change History (23)

@audrasjb
3 weeks ago

Upgrade/Install: set auto_update_core_major option to true for new installations

#1 @audrasjb
3 weeks ago

  • Keywords has-patch has-screenshots dev-feedback added

#2 @mukesh27
2 weeks ago

Patch 51743.diff working fine for me on WordPress 5.6-beta3-49552 with the fresh installation.

This ticket was mentioned in Slack in #core-auto-updates by audrasjb. View the logs.


2 weeks ago

This ticket was mentioned in Slack in #core-auto-updates by audrasjb. View the logs.


2 weeks ago

@azaozz
2 weeks ago

#5 @azaozz
2 weeks ago

  • Keywords needs-testing added

In 51743.2.diff: Set the default for the auto_update_core_major option to enabled for new installs and override it to unset on upgrading from a WP version earlier than 5.6.

Please test!

@azaozz
2 weeks ago

#6 @azaozz
2 weeks ago

In 51743.3.diff:

  • Populate the three new auto-update options: auto_update_core_dev, auto_update_core_minor, and auto_update_core_major.
  • Add some more inline comments.

These pre-populated options apply only to single site installs despite that they are set/read with update_site_option() and get_site_option(). To do the same for multisite/network installs it seems the code will have to be in upgrade_network() and (perhaps) in populate_network() in schema.php but not sure if that's needed/a good idea. Pinging @jeremyfelt as the resident multisite/network expert for a quick review :)

Still todo:

  • More testing on existing and new single-site installs.
  • TBD: should new network installs be set to do major core auto-updates by default, same as single sites?
Last edited 2 weeks ago by azaozz (previous) (diff)

This ticket was mentioned in Slack in #core-auto-updates by hellofromtonya. View the logs.


2 weeks ago

This ticket was mentioned in Slack in #core by helen. View the logs.


2 weeks ago

@helen
2 weeks ago

#9 @helen
2 weeks ago

In 49581:

Upgrade/Install: Enable all core autoupdates for new installs.

Likely needs more work for multisite installs.

Reference: https://make.wordpress.org/core/2020/11/10/wp5-6-auto-update-implementation-change/

Props audrasjb, azaozz.
See #51743.

This ticket was mentioned in Slack in #core-auto-updates by pbiron. View the logs.


2 weeks ago

#11 @helen
11 days ago

Does this ticket need anything else? Do we need to address multisite at all? My view is that by nature multisite is still really meant for a more hands-on admin so I don't know that autoupdates on by default makes sense right now. That said, is it weird if somebody has explicitly turned major autoupdates on in the UI and then converts to multisite and it's off again? Is it okay to call that a multisite conversion quirk for now? I am not strongly opinionated, hoping somebody else feels strongly enough about this to advocate for a direction before RC :)

This ticket was mentioned in Slack in #core-auto-updates by hellofromtonya. View the logs.


10 days ago

This ticket was mentioned in Slack in #core-auto-updates by hellofromtonya. View the logs.


10 days ago

#14 @audrasjb
10 days ago

  • Keywords dev-feedback needs-testing removed

FWIW, I'm fine with the current implementation _for now_. Multisites can be handled in the next release. Also, they still have the possibility to opt-in to auto-updates once the multisite is set up.

#15 @pbiron
10 days ago

I concur with @audrasjb.

Ultimately, when a single site is converted to a multisite, it would be good if the multisite "inherited" the current setting for the single site during conversion, but I seriously doubt we can get a working/tested patch before RC1 (in a few hours). I know I certainly don't have time.

This "quirk" should be made very explicit in the dev-note so that MS admins are aware.

#16 @audrasjb
10 days ago

This "quirk" should be made very explicit in the dev-note so that MS admins are aware.

Absolutely. FYI I'm working on the dev note right now, I'll let you know when it's ready for review.

This ticket was mentioned in Slack in #core-auto-updates by hellofromtonya. View the logs.


10 days ago

#18 @audrasjb
10 days ago

  • Resolution set to fixed
  • Status changed from new to closed

Closing as fixed. We'll open a new ticket to handle next steps for multisites.

Note: See TracTickets for help on using tickets.