#51749 closed task (blessed) (fixed)
Update engines in package.json to match new LTS
Reported by: | mkaz | Owned by: | desrosj |
---|---|---|---|
Milestone: | 5.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | has-patch |
Focuses: | javascript | Cc: |
Description
The engine field in package.json specifies a specific version 12.16.0 and 6.14.0, this should probably be set to greater-than-or-equal-to and not exact.
Since the .npmrc file does not specify that engine-strict=true, as it does in the Gutenberg repository, this field is advisory only.
The advice in documentation is to using the current LTS version, this also matches the .nvmrc file which is set to lts/*
So this ticket updates the package.json to >=14.15.0 and >=6.14.8 for node and npm, respectively.
See engines documenation:
https://docs.npmjs.com/cli/v6/configuring-npm/package-json#engines
Attachments (1)
Change History (8)
#1
@
4 years ago
- Component changed from General to Build/Test Tools
- Keywords has-patch added
- Milestone changed from Awaiting Review to 5.6
- Type changed from defect (bug) to task (blessed)
#2
@
4 years ago
I think this should be OK to make today before RC1, but I am leaning towards defining a specific version (14.15.0
) instead of a range. It looks like this has been the practice in the past branches.
@jorbin do you happen to know any details from past releases around defining this?
#3
@
4 years ago
@desrosj This is something that generally has been coordinated with systems to ensure that the build server has the correct version. This had at one time been specific versions of node, hence not having a range. No idea what the case is now.
I just reached out to the systems team to confirm 14.x was available on the build server. It was not, but it has been added, so this can now be considered.
I'm also going to convert this to a task since it is a build tool related ticket.