Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#51760 closed enhancement (fixed)

Block Editor: port custom-spacing theme support

Reported by: oandregal's profile oandregal Owned by: oandregal's profile oandregal
Milestone: 5.7 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch commit
Focuses: Cc:

Description

The property custom-spacing was deemed stable so it's ready to be ported to WordPress core during the 5.7 cycle, when trunk is open.

Change History (15)

#1 @desrosj
3 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.7
  • Version trunk deleted

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


3 years ago

This ticket was mentioned in Slack in #core by lukecarbis. View the logs.


3 years ago

#4 @noisysocks
3 years ago

Hi @nosolosw. Are you able to add a patch for this? Not sure which PHP code needs to be copied over 🙂

nosolosw commented on PR #951:


3 years ago
#5

I've also prepared the changes in Gutenberg.

#6 @oandregal
3 years ago

:wave: @noisysocks this needs two things:

#7 @gziolo
3 years ago

  • Keywords has-patch commit added; needs-patch removed

#8 @gziolo
3 years ago

This is ready to go with the patch included. I can commit it tomorrow unless @noisysocks beats me to it  😃

#9 @noisysocks
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 50070:

Block Editor: Add enableCustomSpacing

Adds the enableCustomSpacing editor setting. This enables the custom block
spacing feature from Gutenberg.

Props nosolosw, gziolo.
Fixes #51760.

#10 @noisysocks
3 years ago

Done. I think GB28548 needs some work though as that wasn't working for me when I tested it.

This ticket was mentioned in Slack in #core-editor by gziolo. View the logs.


3 years ago

#12 @oandregal
3 years ago

I pushed a fix and https://github.com/WordPress/gutenberg/pull/28548 is working fine now. Will be part of Gutenberg 9.9RC.

#13 @TimothyBlynJacobs
3 years ago

Ideally, we should be registering these in create_initial_theme_features.

This ticket was mentioned in Slack in #core-editor by nosolosw. View the logs.


3 years ago

#15 @a4jp.com
3 years ago

Thank you so much for doing this and if it's okay can you also make div.block-editor-block-listinsertion-point.is-vertical clickable and add the missing plus when you mouse over the top of the first block? It's missing now so impossible to add blocks before the first block. Thank you so much for making the accessibility option in WordPress heaps better with every update.

Version 0, edited 3 years ago by a4jp.com (next)
Note: See TracTickets for help on using tickets.