Display version number in update-core.php `Re-install Now` button

[afragen]

Currently in the update-core.php page the Re-install Now button only presents the information about which version is being re-installed in the text above the button.

Placing the version inside the button would make this more clear and might allow for the removal of the description string.

[hellofromTonya]

Whoopsie reverting....

[afragen]

updates set for beta/RC

[afragen]

update set for nightly

[afragen]

changed button to be 'Re-install version x.x.x'

[afragen]

using Bleeding edge / nightly

[afragen]

using Bleeding edge / beta/RC

[afragen]

possible fix for non en_US

[afragen]

This will certainly need more non-en_US testing.

[afragen]

update variable to coincide with patch in #51822

[afragen]

simplify preg_match()

[afragen]

update variable name

[audrasjb]

Use sentence case in translatable string

[audrasjb]

Before patch

[audrasjb]

After patch

[afragen]

Moving to commit per today's #core-auto-updates meeting.

[SergeyBiryukov]

This looks good, my only concern here is that if we switch these buttons to sentence case, they don't match the rest of the capitalized buttons on the screen still using Title Case: "Update Plugins", "Update Themes", "Update Translations". Would someone be up for creating a ticket to update those buttons for consistency? Otherwise, that can be included in a general ticket: #49616.

There are also similar buttons on plugin installation screens: "Install Now", "Cannot Install", "Update Now", "Cannot Update", "Install Update Now" that should probably be converted to sentence case too in a future release.

There is one more reference to "Update Now" in Site Health that show be "Update now" after this change, I can adjust that on commit.

[SergeyBiryukov]

In 49984:

Upgrade/Install: Display version number on the "Re-install now" button on WordPress Updates screen.

This makes the button label more clear and allows for removing unnecessary description.

Props afragen, audrasjb.
Fixes #51774.

In #51774 we added the version number to the 'Re-install' button on update-core.php.

I propose we add the version number to the 'Update' button when the user is set to update to the next beta/RC whether they are using the WP_AUTO_UPDATE_CORE constant or the Beta Tester plugin.

The patch identifies the $update->current as a beta or rc offer by prep_match for 2 hyphens in the version number. 2 hyphens indicate a nightly, where a single hyphen indicates a beta or RC offer.

Trac ticket: https://core.trac.wordpress.org/ticket/52513