WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 9 months ago

Last modified 8 months ago

#51774 closed enhancement (fixed)

Display version number in update-core.php `Re-install Now` button

Reported by: afragen Owned by: SergeyBiryukov
Milestone: 5.7 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch has-screenshots commit
Focuses: Cc:

Description

Currently in the update-core.php page the Re-install Now button only presents the information about which version is being re-installed in the text above the button.

Placing the version inside the button would make this more clear and might allow for the removal of the description string.

Attachments (16)

51774.diff (835 bytes) - added by afragen 11 months ago.
version_in_button.png (102.3 KB) - added by afragen 11 months ago.
screenshot_167.png (148.4 KB) - added by afragen 11 months ago.
updates set for beta/RC
screenshot_166.png (130.6 KB) - added by afragen 11 months ago.
update set for nightly
51774.2.diff (1.2 KB) - added by afragen 11 months ago.
51774.3.diff (1.2 KB) - added by afragen 11 months ago.
changed button to be 'Re-install version x.x.x'
nightly.png (131.7 KB) - added by afragen 11 months ago.
using Bleeding edge / nightly
beta-RC reinstall.png (152.7 KB) - added by afragen 11 months ago.
using Bleeding edge / beta/RC
51774.4.diff (1.7 KB) - added by afragen 11 months ago.
possible fix for non en_US
fr_FR nightly.png (97.4 KB) - added by afragen 11 months ago.
51774.5.diff (1.7 KB) - added by afragen 11 months ago.
update variable to coincide with patch in #51822
51774.6.diff (1.6 KB) - added by afragen 11 months ago.
simplify preg_match()
51774.7.diff (1.8 KB) - added by afragen 11 months ago.
update variable name
51774.8.diff (3.1 KB) - added by audrasjb 10 months ago.
Use sentence case in translatable string
Capture d’écran 2020-12-15 à 19.11.57.png (200.1 KB) - added by audrasjb 10 months ago.
Before patch
Capture d’écran 2020-12-15 à 20.24.07.png (172.1 KB) - added by audrasjb 10 months ago.
After patch

Download all attachments as: .zip

Change History (36)

@afragen
11 months ago

#1 @afragen
11 months ago

  • Type changed from defect (bug) to enhancement

#2 @afragen
11 months ago

  • Component changed from General to Upgrade/Install

This ticket was mentioned in Slack in #core-auto-updates by afragen. View the logs.


11 months ago

#4 @hellofromTonya
11 months ago

  • Type changed from enhancement to defect (bug)

#5 @hellofromTonya
11 months ago

  • Type changed from defect (bug) to enhancement

Whoopsie reverting....

@afragen
11 months ago

updates set for beta/RC

@afragen
11 months ago

update set for nightly

@afragen
11 months ago

@afragen
11 months ago

changed button to be 'Re-install version x.x.x'

@afragen
11 months ago

using Bleeding edge / nightly

@afragen
11 months ago

using Bleeding edge / beta/RC

@afragen
11 months ago

possible fix for non en_US

#6 @afragen
11 months ago

  • Keywords has-screenshots added

This will certainly need more non-en_US testing.

This ticket was mentioned in Slack in #core-auto-updates by pbiron. View the logs.


11 months ago

This ticket was mentioned in Slack in #core-auto-updates by afragen. View the logs.


11 months ago

#9 @afragen
11 months ago

  • Milestone changed from Awaiting Review to 5.7

@afragen
11 months ago

update variable to coincide with patch in #51822

@afragen
11 months ago

simplify preg_match()

@afragen
11 months ago

update variable name

#10 @SergeyBiryukov
11 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

@audrasjb
10 months ago

Use sentence case in translatable string

This ticket was mentioned in Slack in #core-auto-updates by audrasjb. View the logs.


10 months ago

This ticket was mentioned in Slack in #core-auto-updates by pbiron. View the logs.


10 months ago

This ticket was mentioned in Slack in #core by afragen. View the logs.


10 months ago

This ticket was mentioned in Slack in #core-auto-updates by afragen. View the logs.


9 months ago

#15 @afragen
9 months ago

  • Keywords commit added; needs-design dev-feedback removed

#16 @afragen
9 months ago

Moving to commit per today's #core-auto-updates meeting.

#17 @SergeyBiryukov
9 months ago

This looks good, my only concern here is that if we switch these buttons to sentence case, they don't match the rest of the capitalized buttons on the screen still using Title Case: "Update Plugins", "Update Themes", "Update Translations". Would someone be up for creating a ticket to update those buttons for consistency? Otherwise, that can be included in a general ticket: #49616.

There are also similar buttons on plugin installation screens: "Install Now", "Cannot Install", "Update Now", "Cannot Update", "Install Update Now" that should probably be converted to sentence case too in a future release.

There is one more reference to "Update Now" in Site Health that show be "Update now" after this change, I can adjust that on commit.

#18 @SergeyBiryukov
9 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 49984:

Upgrade/Install: Display version number on the "Re-install now" button on WordPress Updates screen.

This makes the button label more clear and allows for removing unnecessary description.

Props afragen, audrasjb.
Fixes #51774.

This ticket was mentioned in Slack in #core by pbiron. View the logs.


9 months ago

This ticket was mentioned in PR #998 on WordPress/wordpress-develop by afragen.


8 months ago

In #51774 we added the version number to the 'Re-install' button on update-core.php.

I propose we add the version number to the 'Update' button when the user is set to update to the next beta/RC whether they are using the WP_AUTO_UPDATE_CORE constant or the Beta Tester plugin.

The patch identifies the $update->current as a beta or rc offer by prep_match for 2 hyphens in the version number. 2 hyphens indicate a nightly, where a single hyphen indicates a beta or RC offer.

Trac ticket: https://core.trac.wordpress.org/ticket/52513

Note: See TracTickets for help on using tickets.