![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#5181 closed enhancement (fixed)
Refactoring Atom support; baby step #1
| Reported by: | rubys | Owned by: | westi |
|---|---|---|---|
| Priority: | normal | Milestone: | 2.5 |
| Component: | General | Version: | |
| Severity: | normal | Keywords: | has-patch has-docs |
| Cc: | Focuses: |
Description
Overall goal is to converge to a single place each where atom entries are created and consumed. This is a first step.
Move prep_content from wp-app to feed.php; use by both wp-app and feed-atom.
Attachments (2)
Change History (10)
#3
@
19 years ago
With prep_content no longer in the AtomServer namespace, does it need a more specific function name. prep_content() seems a bit generic. Other than that, looks good to me. If you have a suggestion for a new function name, I can make the change and commit. However, I'm fine with prep_content() if that's what you want.
#4
@
19 years ago
- Keywords has-patch needs-docs added
Looks good.
Can we have some phpdoc for prep_atom_text_construct please.
#5
@
19 years ago
- Cc added
I *knew* there was a reason why I wanted to do this with baby steps. :-)
This is my first time writing phpdoc. If I get something minor wrong, please feel free to correct it. If I get something major wrong, simply toss it back and point me in the right direction.
#6
@
19 years ago
- Keywords has-docs added; needs-docs removed
- Owner changed from to
- Status new → assigned
+1
phpdoc enabled patch looks good
Joseph Scott suggested that I should mention that this fix passes both APE and the Feed Validator when applied against revision 6220. Revisions 6221-6243 don't pass APE (with or without this fix), due to bug 5180. Revisions 6228-HEAD don't pass Feed Validation (with or without this fix), due to bug 5194.