WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 3 months ago

Last modified 3 months ago

#51810 closed task (blessed) (fixed)

GitHub Actions: Verify compatibility with Ubuntu 20.04

Reported by: desrosj Owned by: desrosj
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:

Description

Starting November 30, GitHub will begin rolling out an update that changes the ubuntu-latest alias to point to ubuntu-20.04 instead of ubuntu-18.04.

This update does come with lots of changes, but the WordPress Core workflows should largely be unaffected because they either configure the needed software using the appropriate official actions, or run tasks within the local Docker containers.

We should test to be sure that this will not cause any issues with our workflows to confirm.

Full details can be found on the related GitHub issue.

Change History (6)

This ticket was mentioned in PR #750 on WordPress/wordpress-develop by desrosj.


4 months ago

  • Keywords has-patch added

The ubuntu-latest alias will switch from pointing to ubuntu-18.04 to ubuntu-20.04 starting November 30th. Let's verify everything works.

Ticket: https://core.trac.wordpress.org/ticket/51810.

#2 @desrosj
4 months ago

  • Keywords has-patch removed
  • Type changed from defect (bug) to task (blessed)

It looks like we'll be good once this change rolls out based on testing in the above PR.

As of right now, the notices added to jobs cannot be dismissed. Though I don't think we should switch the version to ubuntu-20.04 to silence them, leaving them is not really ideal either.

I commented on the issue requesting a way to dismiss or mark the notice as acknowledged. Leaving this open for now.

#3 @a223123131
4 months ago

What is the exact change?

#4 @desrosj
4 months ago

  • Keywords 2nd-opinion added

@a223123131 If GitHub is able to add a way to dismiss the related notice, then there should be no changes required.

Alternatively, if we feel those notices are too distracting, or that it's better to be explicit in the version of ubuntu used to run the workflows, then ubuntu-latest (currently pointing to ubuntu-18.04) would need to be changed to explicitly specify a version (see the pull request).

#5 @desrosj
3 months ago

  • Keywords 2nd-opinion removed
  • Milestone changed from Future Release to 5.6
  • Resolution set to fixed
  • Status changed from assigned to closed

After thinking this over a bit and discussing with @helen, we decided to remain on ubuntu-latest. While the notices are a bit annoying, it's preferable to remain on latest in order to continue building on the latest image.

The GitHub team is seeing about adding a way to acknowledge or dismiss the notice. If any actionable steps arise, we can reopen.

#6 @prbot
3 months ago

desrosj commented on PR #750:

Looks like we won't have any issue once the canonical image is changed. 👍🏼

Note: See TracTickets for help on using tickets.