Changes between Version 1 and Version 2 of Ticket #51812, comment 26
- Timestamp:
- 01/20/2021 07:58:37 AM (4 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #51812, comment 26
v1 v2 4 4 Thanks for the PR! Just noting it needs a refresh after [49944] / #46872 and [49973] / #52073. 5 5 6 The first three c hanges are fairly easy to resolve (just remove `#doaction2`), but I'm less sure about the change in `js/_enqueues/wp/widgets/text.js`. It looks like the change from this PR takes a different approach at fixing the same issue, so we need to decide on the preferred approach. Since [49973] appears to be tested and confirmed, do we still need `$( window ).on( 'load', ... )` there? /cc @azaozz6 The first three conflicts are fairly easy to resolve (just remove `#doaction2`), but I'm less sure about the change in `js/_enqueues/wp/widgets/text.js`. It looks like the change from this PR takes a different approach at fixing the same issue, so we need to decide on the preferred approach. Since [49973] appears to be tested and confirmed, do we still need `$( window ).on( 'load', ... )` there? /cc @azaozz