WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #51812, comment 26


Ignore:
Timestamp:
01/20/2021 07:58:37 AM (6 weeks ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #51812, comment 26

    v1 v2  
    44Thanks for the PR! Just noting it needs a refresh after [49944] / #46872 and [49973] / #52073.
    55
    6 The first three changes are fairly easy to resolve (just remove `#doaction2`), but I'm less sure about the change in `js/_enqueues/wp/widgets/text.js`. It looks like the change from this PR takes a different approach at fixing the same issue, so we need to decide on the preferred approach. Since [49973] appears to be tested and confirmed, do we still need `$( window ).on( 'load', ... )` there? /cc @azaozz
     6The first three conflicts are fairly easy to resolve (just remove `#doaction2`), but I'm less sure about the change in `js/_enqueues/wp/widgets/text.js`. It looks like the change from this PR takes a different approach at fixing the same issue, so we need to decide on the preferred approach. Since [49973] appears to be tested and confirmed, do we still need `$( window ).on( 'load', ... )` there? /cc @azaozz