Opened 4 years ago
Closed 4 years ago
#51813 closed defect (bug) (fixed)
Latest translations are not consistent
Reported by: | psmits1567 | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.6 | Priority: | normal |
Severity: | normal | Version: | 5.6 |
Component: | I18N | Keywords: | i18n-change commit dev-reviewed |
Focuses: | Cc: |
Description
The new translations for WordPress 5.6 are not consistent with other lines.
The closing dot should be outside HTML.
Examples below:
https://translate.wordpress.org/projects/wp/dev/admin/nl/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=10816869&filters%5Btranslation_id%5D=78658974
If you find issues with the way your site looks (e.g. a slider doesn’t work, a button is stuck — that sort of thing), install the <a href="%s">jQuery Migrate plugin.</a>
https://translate.wordpress.org/projects/wp/dev/admin/nl/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=10816870&filters%5Btranslation_id%5D=78658918
Check out the latest version of the WordPress Field Guide. It highlights developer notes for each change you may want to be aware of. <a href="%s">WordPress 5.6 Field Guide.</a>
Attachments (1)
Change History (15)
This ticket was mentioned in Slack in #polyglots by psmits1567. View the logs.
4 years ago
#3
@
4 years ago
- Component changed from Administration to I18N
- Milestone changed from Awaiting Review to 5.6
- Version set to trunk
Related: #51415
See comment 30: https://core.trac.wordpress.org/ticket/51415#comment:30
This ticket was mentioned in Slack in #polyglots by tobifjellner. View the logs.
4 years ago
#5
@
4 years ago
It will be good for styling to get rid of double mentioning "WordPress Field Guide"
as suggested by @markscottrobson at #polyglots:
Also, it’s probably better to say “It highlights developer notes for each change of which you may want to be aware.”.
This ticket was mentioned in Slack in #accessibility by sergey. View the logs.
4 years ago
#8
@
4 years ago
Hi there, thanks for ticket!
It looks like only the first instance should be changed here:
...install the <a href="%s">jQuery Migrate plugin</a>
is a part of the sentence, so the dot should indeed be outside of the<a>
tag.- On the other hand,
WordPress 5.6 Field Guide.
is a separate sentence, which should probably remain as is.
Let's use #51415 for any additional text changes or suggestions, to get more eyes on them and keep the discussion in one place.
#9
@
4 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 49685:
#10
@
4 years ago
- Keywords commit dev-feedback added; needs-patch removed
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for backporting to the 5.6 branch after a second committer's review.
In the string
the word "looks" would better be replaced for "behaves" or "functions".
+ Another string in the same file seems to have a placeholder that should have been either replaced with proper text or at least changed into string placeholders, namely: