WordPress.org

Make WordPress Core

Opened 9 days ago

Last modified 4 days ago

#51813 reopened defect (bug)

Latest translations are not consistent

Reported by: psmits1567 Owned by: SergeyBiryukov
Milestone: 5.6 Priority: normal
Severity: normal Version: 5.6
Component: I18N Keywords: i18n-change commit dev-feedback
Focuses: Cc:

Description

The new translations for WordPress 5.6 are not consistent with other lines.
The closing dot should be outside HTML.
Examples below:
https://translate.wordpress.org/projects/wp/dev/admin/nl/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=10816869&filters%5Btranslation_id%5D=78658974
If you find issues with the way your site looks (e.g. a slider doesn’t work, a button is stuck — that sort of thing), install the <a href="%s">jQuery Migrate plugin.</a>

https://translate.wordpress.org/projects/wp/dev/admin/nl/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=10816870&filters%5Btranslation_id%5D=78658918
Check out the latest version of the WordPress Field Guide. It highlights developer notes for each change you may want to be aware of. <a href="%s">WordPress 5.6 Field Guide.</a>

Attachments (1)

51813.diff (1.3 KB) - added by audrasjb 9 days ago.
Help/About: Fix translations inconsistencies in WP 5.6 About page

Download all attachments as: .zip

Change History (11)

This ticket was mentioned in Slack in #polyglots by psmits1567. View the logs.


9 days ago

#2 @tobifjellner
9 days ago

  • Component changed from General to Administration

In the string

If you find issues with the way your site looks (e.g. a slider doesn’t work, a button is stuck — that sort of thing), install the <a href="%s">jQuery Migrate plugin.</a>

the word "looks" would better be replaced for "behaves" or "functions".


+ Another string in the same file seems to have a placeholder that should have been either replaced with proper text or at least changed into string placeholders, namely:

5.6 marks the first steps toward WordPress Core support for PHP 8. Now is a great time to start planning how your WordPress products, services and sites can support the latest PHP version. For more information about what to expect next, [link text].

#3 @audrasjb
9 days ago

  • Component changed from Administration to I18N
  • Milestone changed from Awaiting Review to 5.6
  • Version set to trunk

@audrasjb
9 days ago

Help/About: Fix translations inconsistencies in WP 5.6 About page

This ticket was mentioned in Slack in #polyglots by tobifjellner. View the logs.


9 days ago

#5 @fierevere
9 days ago

It will be good for styling to get rid of double mentioning "WordPress Field Guide"

as suggested by @markscottrobson at #polyglots:
Also, it’s probably better to say “It highlights developer notes for each change of which you may want to be aware.”.

#6 @desrosj
9 days ago

  • Keywords i18n-change added

This ticket was mentioned in Slack in #accessibility by sergey. View the logs.


7 days ago

#8 @SergeyBiryukov
4 days ago

Hi there, thanks for ticket!

It looks like only the first instance should be changed here:

  • ...install the <a href="%s">jQuery Migrate plugin</a> is a part of the sentence, so the dot should indeed be outside of the <a> tag.
  • On the other hand, WordPress 5.6 Field Guide. is a separate sentence, which should probably remain as is.

Let's use #51415 for any additional text changes or suggestions, to get more eyes on them and keep the discussion in one place.

#9 @SergeyBiryukov
4 days ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 49685:

Help/About: Move trailing punctuation in the jQuery Migrate Helper plugin link outside of the HTML tag.

Props psmits1567, audrasjb, tobifjellner, fierevere, markscottrobson.
Fixes #51813.

#10 @SergeyBiryukov
4 days ago

  • Keywords commit dev-feedback added; needs-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backporting to the 5.6 branch after a second committer's review.

Note: See TracTickets for help on using tickets.