WordPress.org

Make WordPress Core

Opened 2 months ago

Closed 2 months ago

Last modified 7 weeks ago

#51815 closed defect (bug) (fixed)

Make the URL translatable in wp-admin/includes/class-wp-site-health.php

Reported by: tai Owned by: SergeyBiryukov
Milestone: 5.6 Priority: normal
Severity: normal Version: 5.6
Component: Site Health Keywords: has-patch commit dev-reviewed i18n-change
Focuses: Cc:

Description

Found the URL should be translatable in wp-admin/includes/class-wp-site-health.php

https://build.trac.wordpress.org/browser/trunk/wp-admin/includes/class-wp-site-health.php#L2128

'https://developer.wordpress.org/rest-api/frequently-asked-questions/#why-is-authentication-not-working',

Attachments (1)

i18n_url.diff (860 bytes) - added by tai 2 months ago.

Download all attachments as: .zip

Change History (10)

@tai
2 months ago

This ticket was mentioned in Slack in #core-site-health by tobifjellner. View the logs.


2 months ago

#2 @SergeyBiryukov
2 months ago

  • Milestone changed from Awaiting Review to 5.6

#3 @audrasjb
2 months ago

  • Component changed from I18N to Site Health
  • Keywords needs-refresh added
  • Type changed from enhancement to defect (bug)
  • Version changed from trunk to 5.5

Looks like a good enhancement. Maybe also worth to use numbered placeholders: %1$s, %2$s, etc, for better clarity.

Those strings appeared in WordPress 5.5.

#4 @SergeyBiryukov
2 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 49650:

Site Health: Add missing i18n for the App Passwords documentation link.

Follow-up to [49334].

Props tai.
Fixes #51815.

#5 @SergeyBiryukov
2 months ago

  • Keywords commit dev-feedback added; needs-refresh removed
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Version changed from 5.5 to trunk

Reopening for backporting to the 5.6 branch after a second committer's review.

All the other DevHub reference links in wp-admin are translatable at a glance, so this brings some consistency.

This is a new URL added in [49334], changing the version accordingly.

Haven't refreshed the tab before committing, and didn't see the suggestion about the numbered placeholders :) We do indeed prefer numbered placeholders in translatable strings if there is more than one placeholder, per #19090 and some other tickets. If the string with multiple placeholders is not translatable (as is the case here), I don't have strong feelings either way.

#6 @TimothyBlynJacobs
2 months ago

  • Keywords dev-reviewed added

I'm not sure the REST API handbook supports translation at the moment, but probably good for future proofing.

The other actions links in WP_Site_Health don't use numbered placeholders either.

#7 @SergeyBiryukov
2 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 49652:

Site Health: Add missing i18n for the App Passwords documentation link.

Follow-up to [49334].

Props tai.
Reviewed by TimothyBlynJacobs, SergeyBiryukov.
Merges [49650] to the 5.6 branch.
Fixes #51815.

#8 @SergeyBiryukov
2 months ago

  • Keywords i18n-change added; dev-feedback removed

#9 @hellofromTonya
7 weeks ago

#51814 was marked as a duplicate.

Note: See TracTickets for help on using tickets.