Changes between Initial Version and Version 1 of Ticket #51822, comment 14
- Timestamp:
- 11/28/2020 02:53:21 PM (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #51822, comment 14
initial v1 1 1 Perhaps I'm overthinking it a bit but to identify a `beta` or `RC` "channel", the code currently sets the type of update before making the wp.org API request, and then checks/expects that `$updates[0]->response` is `'development'`. The same is used in `core_upgrade_preamble()`, `core_update_footer()`, `list_core_update()` (twice), `wp_get_update_data()`. 2 2 3 Then 51822.3.diff changes only `core_upgrade_preamble()` to use `$wp_version` instead, which makes it a bit inconsistent. What happens if there's an edge case/error with the request and the wp.org API doesn't return `'development'`? Seems that perhaps the Beta Tester plugin could be extended to handle this case better.3 Then 51822.3.diff changes only `core_upgrade_preamble()` to use `$wp_version` instead, which makes it a bit inconsistent. What happens if there's an edge case/error with the request and the wp.org API doesn't return `'development'`? True, this won't "break" updates, just show (or not show) the appropriate message in the UI. Seems that perhaps the Beta Tester plugin could be extended/enhanced to handle this case better.