| 9 | | The logic is/should be that if `AUTOMATIC_UPDATER_DISABLED` is set and false, it is equivalent to not being set, i.e. the updater is not disabled. Same for the `'automatic_updater_disabled'` filter. So it should be checking only if any of the two is `true` (updater is disabled). Patch coming up. |
| | 9 | The logic is/should be that if `AUTOMATIC_UPDATER_DISABLED` is set and false, it is equivalent to not being set, i.e. the updater is not disabled. Same for the `'automatic_updater_disabled'` filter. So it should be checking only if any of the two is `true` (updater is disabled). Also the filter overrides the constant. |
| | 10 | |
| | 11 | In addition, seems that `wp_is_file_mod_allowed( 'automatic_updater' )` is not checked. |
| | 12 | |
| | 13 | Thinking perhaps this should use `WP_Automatic_Updater::is_disabled()` instead of trying to duplicate the logic? It already uses the WP_Automatic_Updater to check for version control. |