WordPress.org

Make WordPress Core

Opened 13 months ago

Last modified 12 months ago

#51830 new defect (bug)

Site Health Themes checkout isn't correct about automatic usage of default theme or themes condition in case of a broken theme

Reported by: oglekler Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords:
Focuses: administration Cc:

Description (last modified by SergeyBiryukov)

  1. In absence of a default theme Site Health says:

"Your site does not have any default theme. Default themes are used by WordPress automatically if anything is wrong with your chosen theme."

https://yadi.sk/i/mP_59ss-3AsCCQ

It does not work this way:

  1. PHP error in an active theme:

https://yadi.sk/i/MuqOAQ0kjldWPw

  1. Absence of an active theme:

https://yadi.sk/i/Bzpy1icVk1Csiw

  1. Absence of style.css — theme continues to work

And default theme is only activating automatically if you go to "Appearance > Themes" and formally something is wrong with theme, like an absence of style.css, but even if the theme can work fine but user after opening this page has no chouse what to do. It is not a convenient solution for a user not to see what was wrong and not to have a choice of what to do. More to the subject: #51479

  1. Site Health don't tell about the absence of style.css which is causing the switch to default theme if you are visiting "Appearance > Themes". So, it does not run the same check what is doing this Themes page.

https://yadi.sk/i/XeoY3c1x4rG_IA

Change History (4)

This ticket was mentioned in Slack in #core-site-health by hellofromtonya. View the logs.


12 months ago

#2 @hellofromTonya
12 months ago

  • Component changed from General to Site Health
  • Version 5.6 deleted

Hello @oglekler and welcome to Trac. Thanks for this ticket.

Default theme logic existed before 5.6. Removing Version for now. Dropped into slack to double check.

#3 @Clorith
12 months ago

  • Milestone changed from Awaiting Review to Future Release
  • Version set to 5.2

#4 @SergeyBiryukov
12 months ago

  • Description modified (diff)
Note: See TracTickets for help on using tickets.