Adding `add_theme_support` for html5 for scripts, does not remove the type attribute from `wp-emoji-release.min.js`

[kanlukasz]

This is a follow-up to #42804.

Using: add_theme_support('html5', ['script', 'style']); removes the type attribute from my custom scripts but does not remove it from the default wp-emoji-release.min.js

Eg.:
<script src="https://example.com/wp-includes/js/wp-emoji-release.min.js?ver=5.5.3" type="text/javascript" defer=""></script>

[peterwilsoncc]

Hello @kanlukasz and welcome to trac!

I've been able to confirm the report, the script is loaded using JavaScript in emoji-loader.js and the theme support setting is not passed to the JavaScript to determine if the type attribute should be included.

From ​/src/js/_enqueues/lib/emoji-loader.js:

function addScript( src ) {
        var script = document.createElement( 'script' );

        script.src = src;
        script.defer = script.type = 'text/javascript';
        document.getElementsByTagName( 'head' )[0].appendChild( script );
}

At a quick glance the same issue applies to src/js/_enqueues/lib/zxcvbn-async.js if it's loaded on the front-end of a site. Some external libraries may include the type too but unfortunately they are out of WordPress's control.

[tferry]

Removes the type attribute from emoji scripts and zxcvbn-async.js when theme supports html5 script tags

[SergeyBiryukov]

Thanks for the patch! I don't think the emoji_type_attr filter is needed here, just checking current_theme_supports( 'html5', 'script' ) should be enough. Looks good to me otherwise.

[tferry]

Updated patch without changes to the package-lock.json file

[tferry]

Thanks @SergeyBiryukov! I've also refreshed the patch to remove the changes to the package-lock.json file - not sure how that snuck in...

[tferry]

Removes emoji_type_attr filter

[chaion07]

Thanks to @kanlukasz for reporting this issue. We reviewed this ticket during a recent [bug-scrub session]​https://wordpress.slack.com/archives/C02RQBWTW/p1623096832360300. With Beta 1 coming in a day, checking with @SergeyBiryukov to kindly draw some attention to this. Thank you!

[hellofromTonya]

Today is 5.8 Beta 1. Ran out of time to land this one. Looks really close to ready pending code review. Punting to 5.9.

[audrasjb]

As per today's bug scrub, let's move this ticket to the next milestone for proper review/refresh.

[costdev]

Per the discussion in the bug scrub, I'm adding needs-refresh as patch 51837.3.diff no longer applies cleanly against trunk.

[costdev]

With 6.0 RC1 tomorrow, I'm moving this ticket to the Future Release milestone.

Trac ticket: https://core.trac.wordpress.org/ticket/51837

This PR addresses the issue where the type="text/javascript" attribute is not removed from the default WordPress scripts wp-emoji-release.min.js and zxcvbn.min.js when add_theme_support('html5', ['script', 'style']); is enabled. The add_theme_support function removes the type attribute from custom scripts, but not from these default WordPress scripts.