I18N - Translation strings in privacy-tools.php are inconsistent in it's wording to privacy-tools.js

[transl8or]

All the new strings from the privacy-tools.php have a different wording to the already existing ones in that context that can be found in privacy-tools.js

I suggest here to exchange "data privacy" with "personal data" to have the english text strings consistent for translation with the following:

Invalid request ID when processing user privacy eraser data.
​https://build.trac.wordpress.org/browser/branches/5.6/wp-admin/includes/privacy-tools.php?marks=912#L912
new => Invalid request ID when processing personal data to erase.

Unable to open user privacy export file (archive) for writing.
​https://build.trac.wordpress.org/browser/branches/5.6/wp-admin/includes/privacy-tools.php?marks=532#L532
new => Unable to open personal data export file (archive) for writing.

Unable to add data to user privacy export file (HTML format).
​https://build.trac.wordpress.org/browser/branches/5.6/wp-admin/includes/privacy-tools.php?marks=511#L511
new => Unable to add data to personal data export file (HTML format).

Unable to add data to user privacy export file (JSON format).
​https://build.trac.wordpress.org/browser/branches/5.6/wp-admin/includes/privacy-tools.php?marks=507#L507
new => Unable to add data to personal data export file (JSON format).

Unable to open user privacy export file (HTML report) for writing.
​https://build.trac.wordpress.org/browser/branches/5.6/wp-admin/includes/privacy-tools.php?marks=413#L413
new => Unable to open personal data export (HTML report) for writing.

Unable to open user privacy export file (JSON report) for writing.
​https://build.trac.wordpress.org/browser/branches/5.6/wp-admin/includes/privacy-tools.php?marks=398#L398
new => Unable to open personal data export file (JSON report) for writing.

Unable to protect user privacy export folder from browsing.
​https://build.trac.wordpress.org/browser/branches/5.6/wp-admin/includes/privacy-tools.php?marks=329#L329
new => Unable to protect personal data export folder from browsing.

Unable to create user privacy export folder.
​https://build.trac.wordpress.org/browser/branches/5.6/wp-admin/includes/privacy-tools.php?marks=321#L321
new => Unable to create folder for personal data export.
or => Unable to create personal data export folder.

Invalid email address when generating user privacy export file.
​https://build.trac.wordpress.org/browser/branches/5.6/wp-admin/includes/privacy-tools.php?marks=313#L313
new => Invalid email address when generating personal data export folder.

Invalid request ID when generating user privacy export file.
​https://build.trac.wordpress.org/browser/branches/5.6/wp-admin/includes/privacy-tools.php?marks=307#L307
new => Invalid request ID when generating personal data export file.

Invalid user privacy action.
​https://build.trac.wordpress.org/browser/branches/5.6/wp-admin/includes/privacy-tools.php?marks=107#L107
​https://build.trac.wordpress.org/browser/branches/5.6/wp-admin/includes/privacy-tools.php?marks=119#L119
new => Invalid personal data action.

Unable to initiate user privacy confirmation request.
​https://build.trac.wordpress.org/browser/branches/5.6/wp-admin/includes/privacy-tools.php?marks=31#L31
new => Unable to initiate confirmation for personal data request.

[SergeyBiryukov]

Hi there, thanks for the ticket!

For context, here's also the full list of strings from js/_enqueues/admin/privacy-tools.js​:

• This user’s personal data export link was sent.
• This user’s personal data export file was downloaded.
• No personal data export file was generated.
• An error occurred while attempting to export personal data.
• No personal data was found for this user.
• Personal data was found for this user but was not erased.
• All of the personal data found for this user was erased.
• Personal data was found for this user but some of the personal data found was not erased.
• An error occurred while attempting to find and erase personal data.
• The section has been copied to your clipboard.

[garrett-eclipse]

Thanks @transl8or, as it's already string freeze for 5.6, let's look into this for 5.7.

[xkon]

Thanks for the suggestions @transl8or ! They all make perfect sense.

51849.diff​ adds the suggested changes and also takes care of a couple of extra missed strings :) .

[xkon]

51849.1.diff​ fixes a faulty copy/paste breaking code.

Looks good to me now so marking for commit.

[SergeyBiryukov]

Thanks for the patch!

Looking at [49090] / #51351, this might need a few more changes, specifically in unit tests or wp-includes/user.php, which still has strings referring to "user privacy request" instead of "personal data request" suggested here.

[xkon]

Thanks @SergeyBiryukov , I thought of keeping it just for the mentioned file on the ticket.

I'll go ahead and check all related strings then to updated them :) .

[xkon]

51849.2.diff​ updates other strings as well & phpunit tests also that return OK now.

[SergeyBiryukov]

In 49970:

Privacy: Use more consistent wording for strings related to personal data requests.

This replaces "user privacy" in various error messages with "personal data", for consistency with other existing strings.

Follow-up to [49090].

Props xkon, transl8or.
Fixes #51849.

[SergeyBiryukov]

In 49971:

Privacy: Update unit test files missed in [49970].

See #51849.