WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #51857, comment 24


Ignore:
Timestamp:
12/24/2020 05:03:11 PM (2 months ago)
Author:
afragen
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #51857, comment 24

    initial v1  
    33It is meant to function if the `$dirlist` returns `false` as this is clearly an issue likely relating to the download, extraction , copy process. There's another ticket #51928 to help provide more data for where and when failures happen.
    44
    5 The zipping is done before the any unpacking of the downloaded package and I'm not sure that it should increase the server resources significantly. If this can be demonstrated that would be great. But since the failure seems to be in `copy_dir()`, zipping the current plugin seems like a better solution than ''copying'' the data somewhere and then ''copying'' it back.
     5The zipping is done before the any unpacking of the downloaded package and I'm not sure that it should increase the server resources significantly. If this can be demonstrated that would be great. But since the failure seems to be in `copy_dir()`, zipping and unzipping the current plugin seems like a better solution than ''copying'' the data somewhere and then ''copying'' it back.