WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#51862 closed defect (bug) (fixed)

When the time format is "H:i", an error occurs when operating the calendar on the post edit screen.

Reported by: tmatsuur Owned by: audrasjb
Milestone: 5.6 Priority: high
Severity: major Version: 5.6
Component: Editor Keywords: has-patch
Focuses: Cc:

Description

In version 5.6 RC-1, an error has occurred in the following operation.

1.Open the [Settings]-[General] menu.

2.Select "H:i" in Time Format and save.

3.Edit "Hello world!" In the posted article.

4.Click the date and time in "Publish" of "Status & visibility".

5.Click "Reset" in the displayed calendar.

6.Click "Immediately".

7.Clicking "Date" or "Calendar Help" in the calendar causes an error.

The contents of "Copy Error" are as follows.

TypeError: `month` must be a valid moment object
    at t.default (http://local3/wp-includes/js/dist/components.min.js?ver=7b2eb7033cd3c6d2b4ea663e7d4774a7:23:32344)
    at new t (http://local3/wp-includes/js/dist/components.min.js?ver=7b2eb7033cd3c6d2b4ea663e7d4774a7:23:19705)
    at Yg (http://local3/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:68:243)
    at rh (http://local3/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:98:274)
    at zj (http://local3/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:228:490)
    at Th (http://local3/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:152:223)
    at tj (http://local3/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:152:152)
    at Te (http://local3/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:146:151)
    at http://local3/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:61:68
    at unstable_runWithPriority (http://local3/wp-includes/js/dist/vendor/react.min.js?ver=16.13.1:25:260)

Attachments (1)

b9e82e6a81d704b4cba1479355e398e5.mp4 (564.8 KB) - added by audrasjb 11 months ago.
video screenshot

Download all attachments as: .zip

Change History (10)

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


11 months ago

#2 @audrasjb
11 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.6
  • Priority changed from normal to high
  • Severity changed from normal to major

Hi,

I was able to reproduce the issue using the proposed steps.

Here is the error I have (using "copy error" button):

TypeError: r is not a function
    at http://localhost:8888/wordpress-develop/wordpress-develop/build/wp-includes/js/dist/components.min.js?ver=7b2eb7033cd3c6d2b4ea663e7d4774a7:7:311452
    at Bh (http://localhost:8888/wordpress-develop/wordpress-develop/build/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:126:456)
    at Dj (http://localhost:8888/wordpress-develop/wordpress-develop/build/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:162:476)
    at unstable_runWithPriority (http://localhost:8888/wordpress-develop/wordpress-develop/build/wp-includes/js/dist/vendor/react.min.js?ver=16.13.1:25:260)
    at Da (http://localhost:8888/wordpress-develop/wordpress-develop/build/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:60:280)
    at xb (http://localhost:8888/wordpress-develop/wordpress-develop/build/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:162:231)
    at mk.Events.current (http://localhost:8888/wordpress-develop/wordpress-develop/build/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:236:102)
    at Ei (http://localhost:8888/wordpress-develop/wordpress-develop/build/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:41:59)

@audrasjb
11 months ago

video screenshot

#3 @pbiron
11 months ago

I can reproduce as well. And the problem does not seem to happen in 5.5.3, so it does seem like a regression in 5.6.

#5 @hellofromTonya
11 months ago

A fix has been merge upstream https://github.com/WordPress/gutenberg/pull/27316. Does this upstream fix resolve this ticket?

#6 @audrasjb
11 months ago

  • Keywords has-patch added; needs-patch removed
  • Owner set to audrasjb
  • Status changed from new to accepted

Yep, definitely. But let's wait this being committed as a package update in core :)

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


11 months ago

#8 @hellofromTonya
11 months ago

  • Milestone 5.6 deleted
  • Resolution set to reported-upstream
  • Status changed from accepted to closed

Fixed upstream and committed in [49719].

Last edited 11 months ago by SergeyBiryukov (previous) (diff)

#9 @SergeyBiryukov
11 months ago

  • Milestone set to 5.6
  • Resolution changed from reported-upstream to fixed

Setting the resolution to fixed, just to clarify that the fix did make it into WordPress 5.6.

Note: See TracTickets for help on using tickets.