WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #51863, comment 3


Ignore:
Timestamp:
11/25/2020 07:08:21 PM (6 months ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #51863, comment 3

    v1 v2  
    77As you mention this bug is because the button text is not wrapped in a span in button.js in UI 1.12.1 (and the `.ui-button-text` class is not used any more). However there is a setting for UI Dialog to specify the text for that particular close button that also allows empty string: https://api.jqueryui.com/dialog/#option-closeText. Ideally plugins would use it.
    88
    9 Don't see a really good way to fix this. The styles from UI 1.12.1 don't work in WP. A possible fix seems to be to add `overflow: hidden;` as that button is limited in size to 36x36px.
     9Don't see a really good way to fix this. The styles from UI 1.12.1 don't work in WP. A possible fix seems to be to add `overflow: hidden;` as that button is limited in size to 36x36px which is enough only for the icon.