Make WordPress Core

Opened 3 years ago

Last modified 3 years ago

#51863 closed defect (bug)

jQuery UI dialog close button style is broken — at Version 1

Reported by: marijnkoopman's profile marijnkoopman Owned by:
Milestone: 5.6 Priority: normal
Severity: normal Version: 5.6
Component: External Libraries Keywords: has-screenshots has-patch commit dev-reviewed
Focuses: ui, css Cc:

Description (last modified by SergeyBiryukov)

In 5.6RC1 and 5.6 Nightly the styling of the Close button from a jQuery UI-dialog is different, giving another view of Dialogs. Instead of showing only a cross, like expected, it shows the cross as well as the text “Close”, see attached screenshot.

In 5.5 this text was wrapped in a span element that was hidden using display: none;. In 5.6 with upgraded jQuery this text is in the button element itself, rendering that solution useless. jQuery UI solves that by putting the text away from the screen by use of a gigantic negative text-indent. In WordPress’ Jquery UI Dialog stylesheet there is no CSS at all for .ui-button-icon-only, as there is on jQueryUI.com. I swiftly tried copying the CSS used by jQueryUI but that doesn’t work in WordPress, since WordPress seems to rely on position: absolute; in the dialog header.

Change History (2)

@marijnkoopman
3 years ago

UI-dialog comparison screenshot

#1 @SergeyBiryukov
3 years ago

  • Component changed from General to External Libraries
  • Description modified (diff)
  • Milestone changed from Awaiting Review to 5.6

Hi there, welcome to WordPress Trac!

Thanks for the report, this appears to be a result of updating jQuery UI in [49101] / #50564.

Moving to the milestone for visibility.

Note: See TracTickets for help on using tickets.