Changes between Initial Version and Version 1 of Ticket #51871, comment 15
- Timestamp:
- 11/30/2020 10:39:18 PM (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #51871, comment 15
initial v1 5 5 I do, however, have a couple of other concerns: 6 6 * With this change, the front-end package will include ~250 more strings that are primarily used in the admin. This will increase memory footprint and might have performance implications similar to those previously raised in #19852. Granted, 250 is only 6% of all current front-end strings (4149), but still a non-trivial number. If there was a way to only move the async test strings we need and leave the rest in the admin, I think that would be better. 7 * More importantly, I'm concerned with moving ~250 strings from the admin language project to the front-end while being in string freeze. I don't think translate.wordpress.org will handle that automatically, so translators will have to manually copy and approve each string. Granted, the strings should already be in translation memory, but copying, checking, and approving them is still a lot of work.7 * More importantly, I'm concerned with moving ~250 strings from the admin language project to the front-end while being in string freeze. I don't think translate.wordpress.org will move the translations automatically as well, so translators will have to manually copy and approve each string. Granted, the strings should already be in translation memory, but copying, checking, and approving them is still a lot of work. 8 8 9 9 As an alternative approach, could we load the admin language file on these requests instead, similar to how it's done in `load_default_textdomain()`?