Opened 4 years ago
Closed 4 years ago
#51874 closed task (blessed) (fixed)
Update PHPMailer library to 6.2.0
Reported by: | jrf | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.6 | Priority: | normal |
Severity: | normal | Version: | 5.7 |
Component: | External Libraries | Keywords: | php8 has-patch commit dev-reviewed |
Focuses: | Cc: |
Description
PHPMailer 6.2.0 has just been released and includes a small fix for PHP 8 compatibility.
The version included with WP should be updated.
Full details:
Attachments (1)
Change History (9)
This ticket was mentioned in Slack in #core-php by hellofromtonya. View the logs.
4 years ago
#2
@
4 years ago
- Keywords has-patch commit added
- Milestone changed from Awaiting Review to 5.6
I just reviewed @ayesh's patch and looking at the diff, there is basically no risk, only benefit, so I propose we include this in the WP 5.6 release.
Effectively, there are only four functional changes, three which relate to PHP 8 fixes and one other which doesn't carry any risk either.
Everything else are CS changes.
- https://github.com/Ayesh/wordpress-develop/commit/2d5f609d0733785604d4447576edc11f3b39d08a#diff-13bdcb601c2993d3cbeabd8bae18ed1a56390bbfd7dfe0d32bec702cc843a441R1467
- https://github.com/Ayesh/wordpress-develop/commit/2d5f609d0733785604d4447576edc11f3b39d08a#diff-13bdcb601c2993d3cbeabd8bae18ed1a56390bbfd7dfe0d32bec702cc843a441R2135
- https://github.com/Ayesh/wordpress-develop/commit/2d5f609d0733785604d4447576edc11f3b39d08a#diff-13bdcb601c2993d3cbeabd8bae18ed1a56390bbfd7dfe0d32bec702cc843a441R4531
- https://github.com/Ayesh/wordpress-develop/commit/2d5f609d0733785604d4447576edc11f3b39d08a#diff-13bdcb601c2993d3cbeabd8bae18ed1a56390bbfd7dfe0d32bec702cc843a441R4537
#3
@
4 years ago
Oh and what I nearly forgot to say: thanks @ayeshrajans for the quick turn around on getting a patch ready for this!
#4
@
4 years ago
- Keywords dev-feedback added
Adding the dev-feedback
keyword so this ticket shows up in the "Commit Candidates which need Dev Review" section on Next Major Release, Workflow Oriented report.
Tests: https://travis-ci.com/github/Ayesh/wordpress-develop/builds/204326555. Similar to the previous updates, we keep three hunks where we force-ignore phpcs checks. This patch updates to the the otherwise identical copy from upstream 6.2.0 tag.